Closed Bug 492530 Opened 15 years ago Closed 15 years ago

allow aria-labelledby to work in anonymous content

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

originally idea comes from bug 490287 but since that bug's approach was changed and this idea wasn't used but it should to be helpful.
Attached patch patch (deleted) — Splinter Review
Attachment #376911 - Flags: review?(marco.zehe)
Attachment #376911 - Flags: review?(david.bolter)
Attachment #376911 - Flags: review?(marco.zehe) → review+
Comment on attachment 376911 [details] [diff] [review]
patch

Cool to preserve the idea! Will prove useful in other places I think. R=me
Attachment #376911 - Flags: review?(david.bolter) → review+
Comment on attachment 376911 [details] [diff] [review]
patch

Very interesting indeed :)

>+  nsCOMPtr<nsIDOMDocumentXBL> xblDocument;
>+  if (aContent->IsInAnonymousSubtree())
>+    xblDocument = do_QueryInterface(document);

Can you move this initialization down closer to where it is used in the source?

r=me
(In reply to comment #3)
> (From update of attachment 376911 [details] [diff] [review])
> Very interesting indeed :)
> 
> >+  nsCOMPtr<nsIDOMDocumentXBL> xblDocument;
> >+  if (aContent->IsInAnonymousSubtree())
> >+    xblDocument = do_QueryInterface(document);
> 
> Can you move this initialization down closer to where it is used in the source?

It's right before while loop. So I can't move it down.
checked in, http://hg.mozilla.org/mozilla-central/rev/191c8cee40e8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: