Closed
Bug 492659
Opened 15 years ago
Closed 15 years ago
Double unlock in js_SetProtoOrParent
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file)
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
As a result of my changes for the bug #489501 js_SetProtoOrParent from jsobj.cpp now contains:
JS_UNLOCK_OBJ(cx, obj);
bool ok = !!js_GetMutableScope(cx, obj);
JS_UNLOCK_OBJ(cx, obj);
instead of intended LOCK/UNLOCK pair. Note that it was really hard to sport this when checking the patch, so all blame goes on myself. This resulted in the mochi test faulires with a debug build, see bug 465131 comment 1.
|
Assignee | |
Comment 1•15 years ago
|
||
Nominating for 1.9.1 as this is a regression from a 1.9.1 blocker.
Flags: blocking1.9.1?
|
||
Updated•15 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
|
|
Assignee | |
Comment 2•15 years ago
|
||
changing the code to use the intended LOCK/UNLOCK pair
Assignee: general → igor
Attachment #377023 -
Flags: review?(mrbkap)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 377023 [details] [diff] [review]
fix
IMO patches this simple shouldn't require review.
Attachment #377023 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #3)
> IMO patches this simple shouldn't require review.
Sorry for the review spam - for me the time it takes to follow the procedure is a very good remainder that should help not do such stupid bugs in the future.
|
|
||
Comment 5•15 years ago
|
||
Don't worry about it. I wasn't complaining to you. I know the feeling of trying to work too fast (and wasting a bunch of time as a result)!
|
||
Updated•15 years ago
|
Priority: -- → P1
|
|
||
Comment 6•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•15 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•