crash [@ nsFolderCompactState::FinishCompact()] on crash-stats. all windows crashes at #40 = about one per day for 3.0b2, just above bug 484550 in frequency none found for 3.0b3pre no comments in any of the crashes bp-9fe43003-e56b-43bf-bd2a-11ecc2090512 0 thunderbird.exe nsFolderCompactState::FinishCompact nsMsgFolderCompactor.cpp:411 1 thunderbird.exe nsFolderCompactState::StartCompacting nsMsgFolderCompactor.cpp:372 2 thunderbird.exe nsFolderCompactState::Compact nsMsgFolderCompactor.cpp:257 3 thunderbird.exe nsMsgLocalMailFolder::Compact nsLocalMailFolder.cpp:860 4 xpcom_core.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101

The crash occurs at: m_db->SetSummaryValid(PR_TRUE); presumably because m_db is null. I added a simple check for that. However, looking through the code, I tried to find a condition where m_db could be null. At http://hg.mozilla.org/comm-central/file/0e339aad00cf/mailnews/base/src/nsMsgFolderCompactor.cpp#l302 a call to InitDB is done with no error checks. But InitDB can fail internally, and when it does m_db does not get set. So proceeding on the theory that failure of InitDB is the root cause, I added checks and recovery from that as well.

Comment on attachment 377170 [details] [diff] [review] Cleanup from InitDB failure yes, this looks like it's worth trying, thx.

Checked in: http://hg.mozilla.org/comm-central/rev/d2dd24f2b0b0