Closed
Bug 492914
Opened 16 years ago
Closed 16 years ago
TM: trace aborts due to flat closure analysis bug
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: bzbarsky, Assigned: brendan)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
Details |
See attached testcase. It triggers aborts like so: abort: 5500: fp->scopeChain is not global or active call object Abort recording of tree /Users/bzbarsky/test.js:3@17 at /Users/bzbarsky/test.js:12@0: name. Note that if I inline looper() in the testcase (so replace that function call to looper() with two nested loops with f() called in the inner loop) then we trace this.
![]() |
Reporter | |
Updated•16 years ago
|
Flags: blocking1.9.1?
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.1
Assignee | ||
Comment 2•16 years ago
|
||
![]() |
Reporter | |
Comment 3•16 years ago
|
||
fwiw, I tried that patch on the go game. It fixed all the board.js scope chain aborts except for the two that actually change the value of a variable the close over.
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 377336 [details]
testcase
Not this bug's test, naming f changes semantics and differs from the go game. I'll put this in a new bug.
/be
Attachment #377336 -
Attachment is obsolete: true
Updated•16 years ago
|
Attachment #377341 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #4) > I'll put this in a new bug. bz kindly offered to do the deed. /be
Assignee | ||
Updated•16 years ago
|
Summary: TM: trace aborts if function that accesses upvar is passed to another function, then called → TM: trace aborts due to flat closure analysis bug
Assignee | ||
Comment 7•16 years ago
|
||
Fixed in tm: http://hg.mozilla.org/tracemonkey/rev/010768e6119c /be
Whiteboard: fixed-in-tracemonkey
Updated•16 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
Comment 9•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/010768e6119c
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 10•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9d6c41d66a07
Keywords: fixed1.9.1
Comment 11•16 years ago
|
||
This has been backed out from 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f497e113346f
Keywords: fixed1.9.1
Comment 12•16 years ago
|
||
(In reply to comment #11) > This has been backed out from 1.9.1: > > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f497e113346f yep, sorry I missed the note here.
Comment 13•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/76b7399a3b54
Keywords: fixed1.9.1
This caused regression bug 495045.
You need to log in
before you can comment on or make changes to this bug.
Description
•