Closed
Bug 492915
Opened 15 years ago
Closed 14 years ago
TM: Using ++ on property of an Object whose name is in a var falls off trace
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files, 1 obsolete file)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
See attached testcase. It falls off trace on the x.a++ line.
Flags: blocking1.9.1?
Reporter | ||
Comment 1•15 years ago
|
||
Attachment #377337 -
Attachment is obsolete: true
Reporter | ||
Updated•15 years ago
|
Summary: TM: Using ++ on property of an Object falls off trace → TM: Using ++ on property of an Object whose name is in a var falls off trace
Updated•15 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
Updated•15 years ago
|
Assignee: general → gal
Comment 2•15 years ago
|
||
Why are we blocking on this?
Agree: we'd take a fix (once we run out of blockers) but wouldn't block.
Flags: wanted1.9.1+
Flags: blocking1.9.1-
Flags: blocking1.9.1+
Assignee | ||
Comment 4•14 years ago
|
||
Taking - I have a fix for this. Pretty simple with imacros.
Assignee: gal → jorendorff
Assignee | ||
Comment 5•14 years ago
|
||
As I typed that I knew I should've attached the work in progress, but for whatever reason I didn't. Anyway, I'm now in the middle of an epic fsck to recover this patch among other things.
It was a great patch, really. You would've liked it.
Comment 7•14 years ago
|
||
Comment on attachment 443114 [details] [diff] [review]
v1
Steal -- nice imacros!
Indentation in tests seems slightly off.
Hope your fsck went well. Did I ever mention writing BMH superlinear search in a miniroot environment (single-user recover boot) to find pieces of jsregexp.c on my old SGI's EFS partition after it corrupted itself (kernel bug for sure)? Late 1997, I think. It was not fun.
/be
Attachment #443114 -
Flags: review?(gal) → review+
I think it was the summer of 1997. You were supposed to come to dinner with me and robm, but instead spent the evening in bldg 2 with your block devices.
Comment 9•14 years ago
|
||
Comment on attachment 443114 [details] [diff] [review]
v1
Its always ok to steal from me :)
Assignee | ||
Comment 10•14 years ago
|
||
Fixed the indentation. Stupid tab characters.
http://hg.mozilla.org/tracemonkey/rev/b7ab81f30d41
Whiteboard: fixed-in-tracemonkey
Comment 11•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•