nsIMsgFolder::isCommandEnabled should die
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Unassigned)
Details
Comment 1•15 years ago
|
||
Reporter | ||
Comment 2•5 years ago
|
||
We should revive this. From skimming it, there's not necessarily too much to do
https://searchfox.org/comm-central/search?q=folder.*.isCommandEnabled&case=false®exp=true&path=
- removing https://searchfox.org/comm-central/rev/72694e3d97e48704952acf28871e0b64a38081f9/mailnews/imap/src/nsImapMailFolder.cpp#8147 and checking the places those few commands are used. Apparently all it's really doing is checking if we're offline.
aceman, any interest?
It seems to be an interesting concept that the folder itself knows whether it can be renamed or deleted right now (e.g. due to being offline). It is useful for IMAP, but may also be useful for some future folder types.
What should we replace it with? Should the front-end know about the folder type peculiarities? I'm not sure about that. We have enough hard-coding of account types in the front-end that should be pushed down to the server implementation in some way and this bug here seems to me to go in the opposite direction.
Reporter | ||
Comment 4•5 years ago
|
||
I think it's very hard to avoid the hard coding of account types in the front-end. Anyway, we already have canRename and canCompact (which would/should!) give you this knowledge to begin with. Checking if a named front-end command is enabled by querying the back-end for that is simply wrong. We don't have a folder.canDelete, but that could be added.
Updated•2 years ago
|
Description
•