If a theora video contains offset information, that information is not respected by Firefox. Firefox happily displays information outside the cropping boundary. Most often this appears as a green border like on the left of this video: http://commons.wikimedia.org/wiki/File:ISS_S6_truss_to_39A.ogg Here is a test video that displays a message if the cropping area is not clipped: http://v2v.cc/~j/theora_testsuite/offset_test.ogv Steps to reproduce: 1) Visit http://v2v.cc/~j/theora_testsuite/offset_test.ogv What you see ============ A video with the message "If you can read this the player you've got there does not offset". What you should see =================== The video with that message cropped out.

Is this the same as bug 488951?

The fix in that bug only addresses the 2nd comment you raised. This addresses the first. For some reason I thought that bug was resolved which is why I raised this one for the missing first part of your comment.

It would be nice to have a reftest here.

(In reply to comment #5) > It would be nice to have a reftest here. Done! The latest patch in bug 488951 adds a reftest that uses a video with an offset. Just in case anyone wants to generate similar test files, here's the process I used: * generate a suitable PNG image * edit libtheora/examples/png2theora.c near theora_info_init to set the picture region (in frame_width and frame_height) and offset. Note that the offset MUST be divisible by 2. Offset origin is top left (mentioning this as the offset origin in the theora bitstream is bottom left). * recompile png2theora and feed it my frame to generate a theora file * verify the result using ogginfo to check the dimensions and offset (accounting for any padding theora had to introduce), and VLC and QuickTime + XiphQT to check that the result video looks correct

verified FIXED on builds: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre ID:20090601044045 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090528 Minefield/3.6a1pre ID:20090528043233