The following test Open the options dialog, opens the privacy pane, re-opens the options dialog and verifies if the privacy pane is open. This test case won't work on Windows until the Bug listed in the "Depends On" section is fixed. It references litmus testcases: * Testcase ID #5971 - Options (Preferences) dialog state retention * Testcase ID #5972 - Open and dismiss the Options (Preferences) dialog

Comment on attachment 378449 [details] testOptions/testOptionsDialogRetention.js >const gDelay = 1000; Please think about that this should always be 0 when requesting review. >var testOptionsDialogRetention = function() { > > // Open the options dialog window > controller.click(new elementslib.ID(controller.window.document, "menu_preferences")); > controller.sleep(gDelay); > var window = mozmill.wm.getMostRecentWindow(''); > var prefController = new mozmill.controller.MozMillController(window); This is the wrong way of opening the preferences dialog. Please use the controller.menus API for the click call. Further please move it to its own function. We use it at least twice in this test module. > // Select the Privacy Pane in the Options Dialog Window > var paneCheck = '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"panePrivacy","label":"Privacy"}'; Please select another pane before you show the privacy pane. You don't know in which state the preferences dialog will stay when you open it the first time. Also remove the label attribute and call it privacyButton. Please always call this dialog preferences. > // Close the Options Dialog Window > var prefWindow = new elementslib.Lookup(prefController.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})'); > prefController.keypress(prefWindow,27,false,false,false,false); Can you please move this to a helper function. We will use it at least 3 times. > // ReOpen the Options Dialog Window > controller.sleep(gDelay); > controller.click(new elementslib.ID(controller.window.document, "menu_preferences")); > > var window = mozmill.wm.getMostRecentWindow(''); > var prefCheck = new mozmill.controller.MozMillController(window); As said above, it should be in its own function. > // Check if the Privacy Pane is retained > var checkNode = new elementslib.ID(prefCheck.window.document, 'panePrivacy'); > controller.sleep(gDelay); > utils.delayedAssertNode(prefCheck, checkNode); Please give it a better name like privacyPane. > // Close the Options Dialog Window > var prefCheckWindow = new elementslib.Lookup(prefCheck.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})'); > prefCheck.keypress(prefCheckWindow,27,false,false,false,false); As said, please in its own function.

Do you want the functions within the test-case or in another API file? If so, what would you like the name of the API file to be?

Never mind, changes are being made. Will put up the necessary files soon.

Here's the new test case with a created testOptionsAPI.js file as well

API file for the options testcases. Once this is pushed to the fileset, the functions will be updated to the other pushed test cases.

Comment on attachment 382332 [details] shared-modules/testOptionsAPI.js As said on IRC the API is added by bug 486407.

Comment on attachment 382331 [details] testOptions/testOptionsDialogRetention.js Needs to be updated with the new prefsdialog api when it has been checked-in.

The preferences dialog API has been implemented. See bug 486407 for an example how to implement it.

This one works perfectly for me at least.

Comment on attachment 383810 [details] [diff] [review] testOptionsDialogRetention.js Aakash, this test looks great! We only have to make one small update. Please select at least two panes in the first preference dialog call. It can be that the pref pane was already selected before your test is executed. With that change you have a r+.

Ask and you will receive :)

added delayAssertNode to first pane check

Comment on attachment 384177 [details] [diff] [review] testOptionsDialogRetention.js There is one thing I have seen while running this test: >var prefPaneSetCallback = function(controller) { > > // Select the Advanced Pane in the Options Dialog Window > var firstPane = '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"paneAdvanced","label":"Advanced"}'; > controller.click(new elementslib.Lookup(controller.window.document, firstPane)); > controller.sleep(gDelay); > > // Check if the panel is active in the Options Dialog Window > var node = new elementslib.ID(controller.window.document, 'paneAdvanced'); > UtilsAPI.delayedAssertNode(controller, node); > > // Select the Privacy Pane in the Options Dialog Window > var paneCheck = '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"panePrivacy","label":"Privacy"}'; > > controller.click(new elementslib.Lookup(controller.window.document, paneCheck)); > controller.sleep(gDelay); > > // Check if the panel is active in the Options Dialog Window > var node = new elementslib.ID(controller.window.document, 'panePrivacy'); > UtilsAPI.delayedAssertNode(controller, node); Here we should wait for the pane itself here. Currently we wait for the buttons which are still existent. Sorry for seeing so late but I will remember to run those tests also in an early stage of review. Can you please fix this? And further please remove the label elements inside the Lookup calls. > > // Close the Options Dialog Window > controller.keypress(null, 'VK_ESCAPE', {}); >} > >var prefPaneCheckCallback = function(controller) { > > // Check if the Privacy Pane is retained > var privacyPaneCheck = new elementslib.ID(controller.window.document, 'panePrivacy'); > controller.sleep(gDelay); > UtilsAPI.delayedAssertNode(controller, privacyPaneCheck); > > // Close the Options Dialog Window > controller.keypress(null, 'VK_ESCAPE', {}); >}

Um, Henrik, what do you mean by "we should wait for the pane itself"? The test case is waiting for the pane itself. The button's is labeled as: new elementslib.Lookup(controller.window.document, '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"paneMain","label":"Main"}') and the pane is labeled as: new elementslib.ID(controller.window.document, "paneMain") via the inspector. Also, how would you change the label elements in the lookup calls....

checking for elements in the panes instead of the panes themselves now.

Comment on attachment 384425 [details] [diff] [review] testOptionsDialogRetention.js As talked on IRC yesterday we need to reset the pane first before we can run any test which checks for the retention. I'll add this function and checkin this test.

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.