The video control scrubber bar is composed of 3 pieces -- a static background bar, a bar that shows the amount of data buffered, and playback position bar. The last of these is just for visual style, basically to make the scrubber bar to the left of the thumb a different color than the bar to the right. It's currently updated after a timeupdate event, which isn't really right. For example, while dragging the thumb rapidly the bar will lag behind the thumb's position, and looks disconnected and broken. Updating it from the valueChange callback (when the <scale>'s value changed) fixes this.

The updated patch for bug 493523 removes the need for the last chunk of the v.1 patch.

We could really do with extra spacers on each side of the thumb that we then style separately... that might also allow themes to do :active sliders ;-)

Comment on attachment 378694 [details] [diff] [review] Patch v.2 r=me by code inspection. >+ if (this.type == "scrubber") { >+ // Update the value bar to match the thumb position. >+ var percent = this.value / newValue; >+ this.valueBar.value = Math.round(percent * 10000); // has max=10000 >+ } Not sure whether it helps to do this outside the switch.

Comment on attachment 378694 [details] [diff] [review] Patch v.2 a191=beltzner Won't hold release for this, but should be super-safe. Make sure it bakes for a cycle on mozilla-central before you move it to 1.9.1 This is the only one of your recent batch that makes me really nervous.

Pushed http://hg.mozilla.org/mozilla-central/rev/f645386cbf36

Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4ebcbc3dae4d