Closed
Bug 493933
Opened 16 years ago
Closed 16 years ago
When sorting bookmarks BY NONE we should take in count partitioning
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
When sorting bookmarks naturally (the sorting mode used by all menus and bookmarks views) we don't take in count partitioning, so based on current temp/disk moz_places table status we can end with a different sorting!
I can probably create a test for this.
Flags: in-testsuite?
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → mak77
|
|
Assignee | |
Comment 1•16 years ago
|
||
i'd like to see this fixed in 1.9.1
|
|
Assignee | |
Comment 2•16 years ago
|
||
so, the main purpose here is to make sort by none "predictable", and not a random sorting.
Attachment #378567 -
Attachment is obsolete: true
Attachment #378581 -
Flags: review?(sdwilsh)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 378581 [details] [diff] [review]
patch v1.1
Ugh, yes. r=sdwilsh
This should probably block since we are a bit broken here, and the implications of that aren't well understood.
Attachment #378581 -
Flags: review?(sdwilsh) → review+
|
|
||
Updated•16 years ago
|
Flags: blocking1.9.1?
Whiteboard: [has patch][can land]
|
||
Comment 4•16 years ago
|
||
Comment on attachment 378581 [details] [diff] [review]
patch v1.1
a191=beltzner
Attachment #378581 -
Flags: approval1.9.1+
|
|
||
Updated•16 years ago
|
Flags: wanted1.9.1+
Flags: blocking1.9.2?
Flags: blocking1.9.1?
Flags: blocking1.9.1-
|
|
Assignee | |
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][can land]
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Keywords: fixed1.9.1
|
||
Updated•15 years ago
|
Flags: blocking1.9.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•