Closed Bug 494126 Opened 16 years ago Closed 8 years ago

Text is vertically offset in input on http://cupertino.org/

Categories

(Core :: Layout: Form Controls, defect)

1.9.2 Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: tchung, Unassigned)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre Build Identifier: The text in the searchbox on the URL is offset in the div. This only happens on trunk, and not on 191 branch. See screenshot: http://www.grabup.com/uploads/ff028fbb1029bff770140f25e92fb082.png The source file is attached. Search for "searchbox" Reproducible: Always Steps to Reproduce: 1. Install 5/20/2009 trunk build. go to URL 2. Click on the upper right corner searchbox 3. type in something. Verify the text is offset in the searchbox div * This looks normal on 1.9.1branch Actual Results: Text is offset in searchbox, and bleeds out of the border. See screenshot: http://www.grabup.com/uploads/ff028fbb1029bff770140f25e92fb082.png Expected Results: Text should be contained within searchbox
Attached file Search Text box source (deleted) —
Attachment #378798 - Attachment mime type: text/html → text/plain
I'm guessing that this was caused by bug 481751. Can somebody confirm?
Blocks: 481751
Keywords: regression
Summary: http://cupertino.org/ → Text is vertically offset in input on http://cupertino.org/
(In reply to comment #2) > I'm guessing that this was caused by bug 481751. Can somebody confirm? yes: given the regression range I get: OK http://hg.mozilla.org/mozilla-central/rev/9703fd69e126 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090518 Minefield/3.6a1pre fails http://hg.mozilla.org/mozilla-central/rev/409416c625bc Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090519 Minefield/3.6a1pre http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9703fd69e126&tochange=409416c625bc
Attached file reduced html,css (deleted) —
(This references an image from http://cupertino.org/.) The input element is 27px high including 4px top-padding (surrounded by red dashed outline). The background image (including border) is 20px high.
Previous behavior was to align the top of the text with the top of the content rect (i.e. bottom of the top-padding) of the input element. Behavior after bug 481751 is to vertically center the text in the content area of the input.
Component: Layout → Layout: Form Controls
QA Contact: layout → layout.form-controls
Need to evaluate whether it's ok to ship like this. :(
Flags: blocking1.9.2?
Seems like a pretty strange use of input boxes to me; if they're going to use a background like that, shouldn't they at least make the input's size match it?
Flags: wanted1.9.2-
Flags: blocking1.9.2?
Flags: blocking1.9.2-
per Bug 525897 sites like Youtube and Apple are affected too.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → 1.9.2 Branch
Cannot reproduce Version 47.0.1 Build ID 20160623154057 User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: