Closed
Bug 494805
Opened 15 years ago
Closed 15 years ago
CacheStoragePermissions() broken for session/localStorage
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
CacheStoragePermissions calls CanAccess of the storage as a security check. I have just found out that nsDOMStorage2 (sessionStorage and localStorage implementation) calls an old nsDOMStorage::CanAccess that only checks domain and NOT the whole principal.
We have to change CacheStoragePermissions to call the correct method somehow, nsDOMStorage2 is wrapping nsDOMStorage.
Flags: blocking1.9.1?
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Comment 2•15 years ago
|
||
How does this bug relate to bug 494810 and bug 494799, if at all?
|
|
||
Comment 3•15 years ago
|
||
Doesn't block, would take patch with tests.
Flags: wanted1.9.1.x?
Flags: blocking1.9.1?
Flags: blocking1.9.1-
|
||
Comment 5•15 years ago
|
||
Fixed on trunk by the fix for bug 495112. Bug 495337 filed as a followup.
http://hg.mozilla.org/mozilla-central/rev/363750f510ec
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Flags: wanted1.9.1.x?
|
||
Updated•12 years ago
|
Group: core-security
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•