Closed
Bug 494838
Opened 15 years ago
Closed 15 years ago
about:privatebrowsing / about:sessionrestore favicon gets reset when pressing Esc while focus is in the location bar
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: polish, regression, verified1.9.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
STR:
1. Enter the private browsing mode. The cursor should be in the location bar.
2. Press Esc.
|
Assignee | |
Comment 1•15 years ago
|
||
Another manifestation:
1. Open about:privatebrowsing in a new tab.
2. Detach the tab to a new window. At this point, no favicon is displayed.
Also:
1. Open about:privatebrowsing in a new tab.
2. Drag the tab to another window. At this point, no favicon is displayed.
This is a regression from bug
Patch forthcoming.
Blocks: 471512
Keywords: regression
|
|
Assignee | |
Comment 2•15 years ago
|
||
It turns out that the affect of |value| on validity check should also be taken into account for about:blank, not for the rest of the initial pages.
Attachment #379716 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Asking wanted based on the use cases in comment 1.
Flags: wanted-firefox3.5?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 379716 [details] [diff] [review]
Patch (v1)
>+ var isBlank = (uri.spec == "about:blank");
let, please?
|
|
||
Updated•15 years ago
|
Component: Private Browsing → General
QA Contact: private.browsing → general
|
|
||
Updated•15 years ago
|
Summary: about:privatebrowsing favicon gets reset when pressing Esc after entering the private browsing mode → about:privatebrowsing / about:sessionrestore favicon gets reset when pressing Esc while focus is in the location bar
|
|
Assignee | |
Comment 5•15 years ago
|
||
(In reply to comment #4)
> (From update of attachment 379716 [details] [diff] [review])
> >+ var isBlank = (uri.spec == "about:blank");
>
> let, please?
Sure.
Attachment #379716 -
Attachment is obsolete: true
Attachment #379719 -
Flags: review?(gavin.sharp)
Attachment #379716 -
Flags: review?(gavin.sharp)
|
||
Updated•15 years ago
|
Attachment #379719 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
|
|
Assignee | |
Updated•15 years ago
|
Attachment #379719 -
Flags: approval1.9.1?
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-litmus?
|
||
Comment 7•15 years ago
|
||
Verified fixed on trunk with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500
Status: RESOLVED → VERIFIED
|
||
Updated•15 years ago
|
Attachment #379719 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 8•15 years ago
|
||
Comment on attachment 379719 [details] [diff] [review]
Patch (v1.1)
a191=beltzner
|
|
Assignee | |
Comment 9•15 years ago
|
||
Flags: wanted-firefox3.5?
Keywords: fixed1.9.1
|
||
Comment 10•15 years ago
|
||
While trying to verify this on 1.9.1 I had some instances where the icon once again disappeared - this was primarily seen using Win XP. In the case where I most recently saw it here is what I did:
1. Enter PB using the tools menu.
2. Used the new tab button to create a blank tab.
3. Switched back to about: PB tab and the icon was blank.
The problem is that I cannot get this happen consistently.
|
|
||
Comment 11•15 years ago
|
||
Verified fixed on 1.9.1 with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528031233
Marcia, I cannot see this problem you mentioned. If you will ever be able to reproduce it please file a new bug. Thanks.
This icon is very noticable for each of our nightly testers. I don't think that we should create a new Litmus test for it. Marcia, can we just include the icon part in any existing test? Just for quick verification.
Keywords: fixed1.9.1 → verified1.9.1
|
|
||
Comment 12•15 years ago
|
||
I think a test case is worth it since I think Ehsan wants to test that after you open new tabs etc that it still show. I will create a test case.
|
|
Assignee | |
Comment 13•15 years ago
|
||
(In reply to comment #12)
> I think a test case is worth it since I think Ehsan wants to test that after
> you open new tabs etc that it still show. I will create a test case.
Agreed. Thanks!
|
||
Comment 14•14 years ago
|
||
Existing testcase should be sufficient:
https://litmus.mozilla.org/show_test.cgi?id=11316
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•