Patrick C. Beard Assignee
	Description • 24 years ago

The MRJ plugin does some skanky stuff when shutting down, that can cause crashes. 
In addition, it doesn't properly release reference counts to the service manager, 
and other services. The enclosed patches make an attempt to fix these problems. 
However, the Plugins system itself will need to be fixed to call the 
nsIPlugin::Shutdown() method to cause proper shutdown.

	sean echevarria
	Comment 2 • 24 years ago

adding dependency on bug 45009: nsIPlugin::Initialize() and ::Shutdown aren't called

	Simon Fraser [no longer active]
	Comment 3 • 24 years ago

Can bug 41880 be dupped to one of these?

	Patrick C. Beard Assignee
	Comment 4 • 24 years ago

I don't own this component, George, would you please consider this for nsbeta3?

	Patrick C. Beard Assignee
	Comment 5 • 24 years ago

Checking in lifetime fixes. It's now or never.

	Patrick C. Beard Assignee
	Comment 6 • 24 years ago

Fixes for lifetime issues are checked in, but can't close this bug until 45009 is 
resolved.

	drapeau
	Comment 7 • 24 years ago

Sorry, Patrick: was on vacation last week.  I'll have Ed Burns look at your 
proposed patch (we're trying to figure this out for Win32 as well), and looks 
like you already took care of the nomination.

	edburns
	Comment 8 • 24 years ago

These fixes look good.

	Patrick C. Beard Assignee
	Comment 9 • 24 years ago

This is a correctness issue, but only rears its head at application shutdown.

	Phil Peterson
	Comment 10 • 24 years ago

PDT agrees P2

	Phil Peterson
	Comment 11 • 24 years ago

I don't see anything in here which sounds like a PR3 stopper, so marking 
nsbeta3-. Also adding the rtm keyword so the patch can be considered for the 
branch before Seamonkey RTM.

	Patrick C. Beard Assignee
	Comment 12 • 24 years ago

These fixes were already checked in, so just waiting for 45009 to close and 
verify.

	shrirang khanzode
	Comment 13 • 24 years ago

qa:junruh

	edburns
	Comment 14 • 24 years ago

Av is waiting for sr=waterson on 45009.

	Patrick C. Beard Assignee
	Comment 15 • 24 years ago

The plugin methods Shutdown() and ShutdownJVM() still aren't getting called with 
the latest tip build. I'm currently testing LiveConnect which doesn't actually 
create an nsIPluginInstance, just an nsIPlugin. So, there are still bugs in the 
plugin code.

	Patrick C. Beard Assignee
	Comment 16 • 24 years ago

This appears to be fixed with latest checkins.

	chris hofmann
	Comment 17 • 24 years ago

can we get it marked fixed....?  thanks

	Patrick C. Beard Assignee
	Comment 18 • 24 years ago

I believe this is now fixed.

	John Unruh
	Comment 19 • 24 years ago

Verified per beard's comments.