It would be great to have simple class members like isLinux, isMac, and isWindows to check on which operating systems we are running the test. It should look like my test is it doing now: https://bug494071.bugzilla.mozilla.org/attachment.cgi?id=379977

There already is a platform string that you can use for that. You can just do a simple string comparison instead of calling a function.

Mikeal, no function will be called. During initialization of Mozmill you can create class members which will be true/false. From now on we even wouldn't have to do a string comparison anymore which will save us time. Think about having Mozmill run on directories with hundreds of tests where we need those checks. Further it makes it more style friendly and you will have a better overview, e.g.: controller.keypress(null, "k", {metaKey: mozmill.isMac, ctrlKey: !mozmill.isMac}); vs controller.keypress(null, "k", {metaKey: (mozmill.platform == "darwin"), ctrlKey: !(mozmill.platform == "darwin")});

Mikeal?

After talking to Mikeal on IRC we clarified my needs and it is on the list for Mozmill 1.2. Reopening for the upcoming work.

Committed revision 472.

Adam, why not simplifying it like: > var isMac = (platform == "darwin");

Simply cranking things out in a rush, if you are that adamant about the implementation feel free to patch.

Alright. That would make more work. Lets push it for a later refactoring. I'll check it right now. Thanks Adam.

Works great. I'll update existing tests.