Closed
Bug 495183
Opened 15 years ago
Closed 14 years ago
Shift text position on the site button for SLL and EV?
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: faaborg, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [polish-hard] [polish-visual][polish-p1])
Now that we have had the SSL domain name on the site button (and of course the EV text), I'm seeing it more often, and something has seemed off. I think it is that it lines up with the text in the location bar, but is drawn on what appears to be a button extending towards the user, while the text in the location bar is drawn in an area that appears to be extending into the screen.
What if we raised the button text one pixel up, (and maybe also to the left / right for rtl)? And then we shifted the text on downpress? Not sure how easy of a change this would be, but I think it might end up looking better.
Reporter | ||
Updated•15 years ago
|
Whiteboard: [polish-hard] [polish-visual][polish-high-visibility]
Comment 1•15 years ago
|
||
This is the counterpart to bug 480903. Attachment 364862 [details] doesn't look quite right to me.
Blocks: 480903
Reporter | ||
Comment 2•15 years ago
|
||
hm, that looks right to me. I think it's the way the center line on the site identity button intersects the text, right now the text feels too low.
Reporter | ||
Comment 3•15 years ago
|
||
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
P1 since it appears in the main window.
Whiteboard: [polish-hard] [polish-visual][polish-high-visibility] → [polish-hard] [polish-visual][polish-p1]
Comment 4•15 years ago
|
||
I agree that the current version doesn't look completely right, but I think it still looks better than attachment 364862 [details].
Moreover, the principle "things that extend to the user are higher" doesn't seem to be used in the Mac OS X UI. For example, I have never seen a button where the icon or the text on the button moves down when it's pressed.
Reporter | ||
Comment 5•15 years ago
|
||
>I have never seen a button where the icon or the text on the button moves down
>when it's pressed.
yeah, that's a good point. Under that approach only Windows classic would actually move the text.
Comment 6•14 years ago
|
||
with the restyling, this works for me. any objections to resolve WFM?
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•