Closed
Bug 495583
Opened 16 years ago
Closed 16 years ago
[SeaMonkey] Remove SUITE_USING_XPFE_DM remnants
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: mpk)
References
()
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b99])
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Reporter | ||
Updated•16 years ago
|
Summary: Remove SUITE_USING_XPFE_DM remnants → [SeaMonkey] Remove SUITE_USING_XPFE_DM remnants
Assignee | ||
Comment 1•16 years ago
|
||
v1.0
Issues addressed in this patch:
- removed all occurrences of ifndef SUITE_USING_XPFE_DM (incl. endif)
- removed all occurrences of ifdef SUITE_USING_XPFE_DM (up to endif)
- removed all references to xpfe/components/download-manager/.../Makefile
in toolkit/toolkit-makefiles.sh
- removed all of xpfe/components/download-manager/
Comment 2•16 years ago
|
||
Now Callek will be unhappy as he wanted to do the honors ;-)
Updated•16 years ago
|
Attachment #380587 -
Flags: review?(neil) → review+
Comment 3•16 years ago
|
||
Comment on attachment 380587 [details] [diff] [review]
v1.0 m-c
[Checkin: Comment 7 & 9]
Shush! By the time he gets his Internet access back he may have forgotten ;-)
Assignee | ||
Comment 4•16 years ago
|
||
Then let's get this landed and blame it on the fairies. ;-)
Keywords: checkin-needed
Reporter | ||
Comment 5•16 years ago
|
||
Comment on attachment 380587 [details] [diff] [review]
v1.0 m-c
[Checkin: Comment 7 & 9]
This is not blocking, (nor landed on trunk (yet),)
but would be a nice removal...
Attachment #380587 -
Flags: approval1.9.1?
Reporter | ||
Updated•16 years ago
|
Whiteboard: [c-n: v1.0 to m-c after m-1.9.1 freeze]
Comment 6•16 years ago
|
||
Comment on attachment 380587 [details] [diff] [review]
v1.0 m-c
[Checkin: Comment 7 & 9]
a191=beltzner, this all looks NPOTB and ifdef'd out to me, right?
Attachment #380587 -
Flags: approval1.9.1? → approval1.9.1+
Reporter | ||
Comment 7•16 years ago
|
||
Comment on attachment 380587 [details] [diff] [review]
v1.0 m-c
[Checkin: Comment 7 & 9]
http://hg.mozilla.org/mozilla-central/rev/30b3e37776f9
Attachment #380587 -
Attachment description: v1.0 m-c → v1.0 m-c
[Checkin: Comment 7]
Reporter | ||
Comment 8•16 years ago
|
||
(In reply to comment #6)
> this all looks NPOTB and ifdef'd out to me, right?
Right, but KaiRo suggested me to ask anyway...
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: v1.0 to m-c after m-1.9.1 freeze] → [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Reporter | ||
Comment 9•16 years ago
|
||
Comment on attachment 380587 [details] [diff] [review]
v1.0 m-c
[Checkin: Comment 7 & 9]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d39c1c3f58aa
Attachment #380587 -
Attachment description: v1.0 m-c
[Checkin: Comment 7] → v1.0 m-c
[Checkin: Comment 7 & 9]
Reporter | ||
Updated•16 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing] → [fixed1.9.1rc1]
Reporter | ||
Updated•16 years ago
|
Whiteboard: [fixed1.9.1rc1] → [fixed1.9.1b99]
You need to log in
before you can comment on or make changes to this bug.
Description
•