Closed Bug 495665 Opened 15 years ago Closed 15 years ago

Crash: Reply to multiple messages [@ nsMsgComposeService::GetOrigWindowSelection]

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
macOS
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: mitra_lists, Assigned: Bienvenu)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090530 Shredder/3.0b3pre When I select multiple messages and hit reply it crashes. This used to work, but I'm not sure when it got broken as its a while since i tried it. Reproducible: Always Steps to Reproduce: 1. Select multiple messages 2. Click Reply Actual Results: Crash Expected Results: Multiple reply windows open I notice that there has been a request Bug 429481 to consolidate the messages when replying - which would be a good idea, and may be worth doing if fixing the bug is too hard. My next step when doing a multi-message reply is to copy and paste the non-unique material from the messages to one of them as a reply.
Looking at the crash point, seems like this could be a regression from bug 454829. Crash stacks: bp-9a5b63a5-4999-4947-aaa2-401832090531 bp-53c9350a-a8c2-4af5-a6fa-7092e2090531 Top of crash stack: 0 thunderbird-bin nsMsgComposeService::GetOrigWindowSelection mailnews/compose/src/nsMsgComposeService.cpp:486 1 thunderbird-bin nsMsgComposeService::OpenComposeWindow mailnews/compose/src/nsMsgComposeService.cpp:593 2 libxpcom_core.dylib NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179 3 thunderbird-bin XPCWrappedNative::CallMethod js/src/xpconnect/src/xpcwrappednative.cpp:2450 4 thunderbird-bin XPC_WN_CallMethod js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590 5 libmozjs.dylib js_Invoke js/src/jsinterp.cpp:1386
Blocks: 454829
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-thunderbird3+
Keywords: crash, regression
Summary: Crash: Reply to multiple messages → Crash: Reply to multiple messages [@ nsMsgComposeService::GetOrigWindowSelection]
Target Milestone: --- → Thunderbird 3.0b3
I think the right antecedent is the grouped actions bug, as I don't think the summary patch itself did anything to how ctrl-r was handled. Changing the dependency structure.
Blocks: 448288
No longer blocks: 454829
I'll take this...
Assignee: nobody → bienvenu
Attached patch proposed fix (deleted) — Splinter Review
sel is null - I suspect it's because of the way we switch out the message pane w/ multiselection, which produces a null selection on the dom window.
Attachment #381094 - Flags: superreview?(bugzilla)
Attachment #381094 - Flags: review?(bugzilla)
Whiteboard: [has patch for review]
Attachment #381094 - Flags: superreview?(bugzilla)
Attachment #381094 - Flags: superreview+
Attachment #381094 - Flags: review?(bugzilla)
Attachment #381094 - Flags: review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I think the initial dependency was right
Blocks: 454829
No longer blocks: 448288
Whiteboard: [has patch for review]
Severity: normal → critical
Crash Signature: [@ nsMsgComposeService::GetOrigWindowSelection]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: