Closed
Bug 495959
Opened 16 years ago
Closed 16 years ago
input inside xul <hbox align="center"/> is not displayed properly
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: arno, Assigned: karlt)
References
Details
Attachments
(4 files)
|
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
|
(deleted),
image/jpeg
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
dbaron
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
screenshot showing the bug
Hi,
with a recent trunk,
<hbox flex="1" align="center">
<html:input value="1"/>
</hbox>
is not displayed correctly: text in html:input is too high.
For some reason, this does not happen for a document opened inside firefox, but a top window document in a xulrunner application (or inside a xul dialog).
|
Reporter | |
Comment 1•16 years ago
|
||
|
||
Updated•16 years ago
|
|
Assignee | |
Comment 2•16 years ago
|
||
Hmm. I couldn't reproduce in Minefield with a toplevel document using dom.disable_window_open_feature.location = false and
netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
window.open("input.xul","_blank","chrome,location=no");
I wonder what might be different in xulrunner.
|
|
||
Comment 3•16 years ago
|
||
Karl, what happens if you run "firefox -chrome url:///to/input.xul"?
|
|
Assignee | |
Comment 4•16 years ago
|
||
Can reproduce with -chrome, thanks!
|
|
Assignee | |
Comment 5•16 years ago
|
||
The lines are not getting reflowed when the block height changes.
NS_FRAME_CONTAINS_RELATIVE_HEIGHT makes the reflow happen.
Attachment #383407 -
Flags: review?(bzbarsky)
|
|
||
Updated•16 years ago
|
Attachment #383407 -
Flags: review?(dbaron)
Attachment #383407 -
Flags: review?(bzbarsky)
Attachment #383407 -
Flags: review+
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 383407 [details] [diff] [review]
set NS_FRAME_CONTAINS_RELATIVE_HEIGHT for relative line-heights
Look ok to me, but a slightly odd use of the flag (which is supposed to mean that the frame has _kids_ with heights that depends on its height, iirc)... David, can you check that over?
|
|
Assignee | |
Comment 7•16 years ago
|
||
|
||
Updated•16 years ago
|
Attachment #383407 -
Flags: review?(dbaron) → review+
|
|
||
Comment 8•16 years ago
|
||
Comment on attachment 383407 [details] [diff] [review]
set NS_FRAME_CONTAINS_RELATIVE_HEIGHT for relative line-heights
Seems ok to me.
|
|
Assignee | |
Comment 9•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•16 years ago
|
||
reftest added:
http://hg.mozilla.org/mozilla-central/rev/144da47d8aad
http://hg.mozilla.org/mozilla-central/rev/794b04051344
Flags: in-testsuite+
Flags: blocking1.9.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•