Closed
Bug 496020
Opened 16 years ago
Closed 16 years ago
nsCSSFrameConstructor::BeginUpdate is called when scripts are not blocked
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I put an assertion that scripts are blocked in nsCSSFrameConstructor::BeginUpdate and it gets hit a lot. Noticed in bug 495728.
Assignee | ||
Comment 1•16 years ago
|
||
Looks like the only place I was seeing this hit was from PresShell::ProcessReflowCommands where we do WillDoReflow() (which calls BeginUpdate) and then calculate our deadline (doesn't seem too dangerous) and then enter a script blocker. Simply moving the WillDoReflow call after the script blocker would fix this if we wanted to.
Comment 2•16 years ago
|
||
I think it's worth doing that, yes. That's the ordering in ResizeReflow() and I'd like us to be consistent between the two.
Assignee | ||
Comment 3•16 years ago
|
||
Assignee: nobody → tnikkel
Attachment #381878 -
Flags: review?(bzbarsky)
Updated•16 years ago
|
Attachment #381878 -
Flags: superreview+
Attachment #381878 -
Flags: review?(bzbarsky)
Attachment #381878 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 4•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•15 years ago
|
||
I don't think we need this on 1.9.1, basically just adding an assertion so we can catch problems.
status1.9.1:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•