Closed
Bug 496721
Opened 15 years ago
Closed 15 years ago
remove fallback CSS background color support
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The CSS WG decided to remove the fallback background color feature from css3-backgrounds (and potentially add an equivalent later using a new value type, e.g., an image() function that takes fallback).
We should remove the implementation that was added in bug 322475.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #381965 -
Flags: superreview?(bzbarsky)
Attachment #381965 -
Flags: review?(bzbarsky)
Comment 2•15 years ago
|
||
:(
This seems like a pretty good feature anyhow, perhaps just change it to a -moz prefixed solution for now?
I think some ui features rely on this, cc'ing dao to weigh in here.
Assignee | ||
Comment 3•15 years ago
|
||
This feature is not in 3.5; I don't think we've done much UI development that's for post-3.5-only. Furthermore, there are much nicer ways to have syntax for the same feature.
Comment 4•15 years ago
|
||
Yeah, we haven't used this yet.
Comment 5•15 years ago
|
||
Comment on attachment 381965 [details] [diff] [review]
patch
r+sr=bzbarsky
Attachment #381965 -
Flags: superreview?(bzbarsky)
Attachment #381965 -
Flags: superreview+
Attachment #381965 -
Flags: review?(bzbarsky)
Attachment #381965 -
Flags: review+
Assignee | ||
Comment 6•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
This fixed the red chin in acid2 right?
Detailed at http://whereswalden.com/2009/02/20/when-good-tests-go-bad-firefox-on-acid2/
Assignee | ||
Comment 8•15 years ago
|
||
Yes.
Updated•15 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 9•15 years ago
|
||
I don't think any documentation is needed here, since we removed a feature that we never shipped in the first place (so that we wouldn't ship it).
Comment 10•15 years ago
|
||
The implementation in bug 322475 was documented, so I need to make sure the background color fallback support isn't part of what got documented. Hence the addition of the doc-needed note here.
Comment 11•15 years ago
|
||
OK, after some reviewing of the docs, this doesn't in fact require any tweaks to the docs, so removing the tag.
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•