This is a top crash in the Firefox 3.0.10 release within the last week: http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.0.10&platform=windows&query_search=signature&query_type=contains&query=Access&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsAccessibleWrap%3A%3Aget_accParent%28IDispatch**%29 Seems to have something to do with tablet PC input, one report mentions returning to the previous page and crashing then. A module named tiptsf.dll is also involved in those of the reports I checked, and according to Microsoft this is a DLL used for the input from the tablet.

Look like we should null check view->GetViewManager()

Ginn, is this what you had in mind?

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid Oops, noticed that we're in Windows, not Solaris or Linux. Reassigning review request.

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid r=me with nits: 1. indenting is off 2. I don't know if returning E_FAIL or E_UNEXPECTED is correct. Would be good to understand why/when we don't get a view manager.

(In reply to comment #4) > (From update of attachment 382475 [details] [diff] [review]) > r=me with nits: > 1. indenting is off Thanks! Fixed locally. I switched to NotePad++ and forgot that it should replace tabs with spaces when auto-indenting. > 2. I don't know if returning E_FAIL or E_UNEXPECTED is correct. I tried to be consistent: Further down in the same method there's another instance where we return E_UNEXPECTED. > Would be good to understand why/when we don't get a view manager. Well way down in the call stack, you see that the destructor of viewManager is called, but further up its constructor is never called again. My guess is that tablet pc asks for the accParent at a time where Firefox is taking away one page and replacing it with another. One commenter said he was going back to the previous page when it crashed on him.

Pushed: http://hg.mozilla.org/mozilla-central/rev/6a4b79ff31e6

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid Requesting approval for 1.9.1.x (but it's not available yet) and 1.9.0.12, was actually found in 1.9.0.10.

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid I hope you didn't check in with tabs instead of spaces. Please fix your editor settings to prevent that in the future.

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid This isn't looking like a topcrash to us anymore, maybe the software in question got updated? We'll look at this after landing on 1.9.1

I corrected the tabs problem locally before checking in, yes! :) We should definitely keep watching out for this and hope those users haven't just given up on Firefox because of this.

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729). Patch caused no regressions, and haven't seen any reports of this type creep up on crash-stats in the last week.

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid Approved for 1.9.0.13, a=dveditz for release-drivers

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid Fourth topmost crasher in Firefox 3.5 within last 7 days: http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.5&platform=windows&query_search=signature&query_type=contains&query=Access&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsAccessibleWrap%3A%3Aget_accParent%28IDispatch**%29

Checking in accessible/src/msaa/nsAccessibleWrap.cpp; /cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v <-- nsAccessibleWrap.cpp new revision: 1.122; previous revision: 1.121 done

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid We'll get this in Firefox 3.5.3

Comment on attachment 382475 [details] [diff] [review] Make sure viewManager is valid Approved for 1.9.1.3, a=dveditz for release-drivers

Fixed in 1.9.1 repo: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/57f2d57a2ab2