Closed
Bug 497450
Opened 15 years ago
Closed 15 years ago
Port new bug 495533 crashtest leak threshold to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: build-config → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #382595 -
Flags: review?(kairo)
|
||
Comment 2•15 years ago
|
||
I can't just easily upgrade buildbotcustom on those boxes, I fear, as all hell would break loose there.
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> I can't just easily upgrade buildbotcustom on those boxes
I feared so about SeaMonkey boxes;
we should do this anyway, but with a '0' Windows threshold for SeaMonkey-Ports (in your bbconf-sm2 repo).
|
|
Assignee | |
Comment 4•15 years ago
|
||
Av1, revised and for bbconf-sm2.
Attachment #382595 -
Attachment is obsolete: true
Attachment #383059 -
Flags: review?(kairo)
Attachment #382595 -
Flags: review?(kairo)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 383059 [details] [diff] [review]
(Av2) Add code and example thresholds
I'm pretty sure that patch would break executing with the call to the step complaining that the element we're using is not set. Please don't comment out those settings, but just have them explicitely in there and set to 0.
Attachment #383059 -
Flags: review?(kairo) → review-
|
|
Assignee | |
Comment 6•15 years ago
|
||
Av2, with comment 5 suggestion(s).
Attachment #383059 -
Attachment is obsolete: true
Attachment #383086 -
Flags: review?(kairo)
|
|
||
Updated•15 years ago
|
Attachment #383086 -
Flags: review?(kairo) → review+
|
|
||
Comment 7•15 years ago
|
||
Comment on attachment 383086 [details] [diff] [review]
(Av3) Add code and '0' thresholds
[Checkin: Comment 8]
r=me. Can CCUnittestBuildFactory already handle that flag?
|
|
Assignee | |
Comment 8•15 years ago
|
||
Comment on attachment 383086 [details] [diff] [review]
(Av3) Add code and '0' thresholds
[Checkin: Comment 8]
http://hg.mozilla.org/users/kairo_kairo.at/bbconf-sm2/rev/6c63af75c7ce
(In reply to comment #7)
> Can CCUnittestBuildFactory already handle that flag?
Yes, Ben updated both factories at the same time :-)
Attachment #383086 -
Attachment description: (Av3) Add code and '0' thresholds → (Av3) Add code and '0' thresholds
[Checkin: Comment 8]
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
|
|
||
Comment 9•15 years ago
|
||
pull and reconfig on the master has been done as I'm working on testing release automation right now (or the first steps for it).
You need to log in
before you can comment on or make changes to this bug.
Description
•