User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042523 Ubuntu/9.04 (jaunty) Firefox/3.0.10 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042523 Ubuntu/9.04 (jaunty) Firefox/3.0.10 Refer to - lirasm<https://bugzilla.mozilla.org/show_bug.cgi?id=484142> Enhancement lirasm - feature of function calls needs to be supported. Reproducible: Always

Adds support to execute the given LIR fragment using --execute option. Implements the basic framework to call C library functions, and adds support to a few functions for demonstration.

Comment on attachment 383301 [details] [diff] [review] add execute option. Implement c library function call support Since I wrote some of the code in this patch, forwarding to graydon for review. There are a few places where this patch is against the js/src style rules, which are here: https://wiki.mozilla.org/JavaScript:SpiderMonkey:C_Coding_Style (Of course a lot of code in js/src breaks the style rules, but new code should try to comply.) >+ opcode = LIR_jt; Use spaces, not tabs. >+ } >+ // Select return type from opcode. You deleted a blank line here. The style rules call for a blank line before a comment line. >+ } >+ else { Style rules call for "} else {" all on one line. > assert(ins); >- > // Save label and do any back-patching of deferred forward-jumps. Another blank line was deleted here.

Er, I didn't actually forward that review request to graydon, since I think paritosh is working on a new version of this patch.

Paritosh, I don't see anything about the --execute flag in this patch.

I added two execution functions for use with '--execute', so floating point returns can be handled. Hopefully the whitespace formatting was fine this time.

Comment on attachment 383776 [details] [diff] [review] lirasm - Add support for calling selected C library functions. Forwarding to graydon for additional review, since I wrote some of that code.

Comment on attachment 383776 [details] [diff] [review] lirasm - Add support for calling selected C library functions. Looks good. Nice work!