Closed
Bug 498212
Opened 16 years ago
Closed 15 years ago
Intermittent nsTArray_base leak in test_nsAbAutoCompleteSearch*.js
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b1
People
(Reporter: standard8, Assigned: ZaneUJi)
References
Details
(Keywords: memory-leak)
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
standard8
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Seen on various leak logs since the first part of bug 438922 landed, but definitely intermittent:
== BloatView: ALL (cumulative) LEAK STATISTICS
|<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev
0 TOTAL 34 4 101542 1 ( 979.77 +/- 1642.76) 232967 0 ( 921.99 +/- 1715.06)
135 nsTArray_base 4 4 25 1 ( 10.71 +/- 5.56) 0 0 ( 0.00 +/- 0.00)
test_nsAbAutoCompleteSearch1.js and 3 seem to get this the most.
|
||
Updated•16 years ago
|
|
Reporter | |
Updated•16 years ago
|
|
|
||
Comment 1•15 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090530
SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/e44d9c0f4805
+http://hg.mozilla.org/comm-central/rev/62f2c362a9a4 + bug 493008 patches)
Ftr, this build already had this bug.
|
Assignee | |
Comment 2•15 years ago
|
||
As the log shows, a nsTArray_base object is created by a destructor.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #422523 -
Flags: review?(bugzilla)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Corrected coding style
Attachment #422523 -
Attachment is obsolete: true
Attachment #423146 -
Flags: review?(bugzilla)
Attachment #422523 -
Flags: review?(bugzilla)
|
|
Reporter | |
Comment 5•15 years ago
|
||
Comment on attachment 423146 [details] [diff] [review]
Patch
Thanks for the patch.
Attachment #423146 -
Flags: superreview?(bienvenu)
Attachment #423146 -
Flags: review?(bugzilla)
Attachment #423146 -
Flags: review+
|
|
Reporter | |
Updated•15 years ago
|
Assignee: nobody → ZaneUJi
|
|
||
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 6•15 years ago
|
||
Comment on attachment 423146 [details] [diff] [review]
Patch
Thx, Zane. I'll try to land this today.
Attachment #423146 -
Flags: superreview?(bienvenu) → superreview+
|
|
||
Comment 7•15 years ago
|
||
fix landed. I've taken the liberty of making the same change to the db cache remove element code.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
|
|
||
Comment 8•15 years ago
|
||
(In reply to comment #7)
http://hg.mozilla.org/comm-central/rev/2044fbaf8ed5
2.8 + if (m_dbCache)
2.9 + m_dbCache->RemoveElement(pMessageDB);
Nit: missing indentation.
|
|
||
Comment 9•15 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•