Closed
Bug 498852
Opened 16 years ago
Closed 15 years ago
allow menu bar auto hiding regardless of toolbar customization
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: ue)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #383670 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 1•15 years ago
|
||
updated to trunk... hasCustomInteractiveItems has been added in bug 499298
Attachment #383670 -
Attachment is obsolete: true
Attachment #385367 -
Flags: review?(gavin.sharp)
Attachment #383670 -
Flags: review?(gavin.sharp)
Comment 2•15 years ago
|
||
I don't understand the reasoning here. Where does "can't be hidden" come from? Hiding a menubar with customized items on it seems to work fine, so I don't understand why we'd prevent it.
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> Hiding a menubar with customized items on it seems to work fine
Seems like this broke at some point. If you open a new window, the menu bar will still be shown.
> I don't understand why we'd prevent it.
Because the items aren't usable this way.
Comment 4•15 years ago
|
||
(In reply to comment #3)
> If you open a new window, the menu bar will still be shown.
Can't we fix that instead?
> > I don't understand why we'd prevent it.
>
> Because the items aren't usable this way.
We don't disable the hiding of other toolbars if they are customized, for good reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar should be an exception.
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > If you open a new window, the menu bar will still be shown.
>
> Can't we fix that instead?
Sure, we could, except that it's currently intentional.
> > > I don't understand why we'd prevent it.
> >
> > Because the items aren't usable this way.
>
> We don't disable the hiding of other toolbars if they are customized, for good
> reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar
> should be an exception.
Users will see the items on the menu bar when pressing Alt and expect them to work.
Comment 6•15 years ago
|
||
(In reply to comment #5)
> Sure, we could, except that it's currently intentional.
What's the reasoning behind that?
> Users will see the items on the menu bar when pressing Alt and expect them to
> work.
Why don't they work then?
Assignee | ||
Comment 7•15 years ago
|
||
(In reply to comment #6)
> (In reply to comment #5)
> > Sure, we could, except that it's currently intentional.
>
> What's the reasoning behind that?
That's the same question as in comment 2, isn't it? The idea is that auto-hiding should be prevented if other items are on the toolbar.
> > Users will see the items on the menu bar when pressing Alt and expect them to
> > work.
>
> Why don't they work then?
Because attempts to use them trigger the DOMMenuBarInactive event, which causes the menu bar to hide.
Comment 8•15 years ago
|
||
Heh, it seems like we're going around in circles here. My expectation is that menubar (auto-)hiding works, regardless of customization state. I would also expect custom menu items on Alt-shown autohidden menubars to work. Are you saying that we can't make them work? Even if that's true, I'm not sure that it means we should disallow auto-hiding. It could still be that someone wants to just hide the menu bar temporarily, in which case they don't care about being able to use it with Alt.
Assignee | ||
Comment 9•15 years ago
|
||
(In reply to comment #8)
> Heh, it seems like we're going around in circles here. My expectation is that
> menubar (auto-)hiding works, regardless of customization state. I would also
> expect custom menu items on Alt-shown autohidden menubars to work. Are you
> saying that we can't make them work?
Custom menuitems would work, as they wouldn't be directly on the toolbar but inside the menubar element. But maybe I misunderstand your question...
Assignee | ||
Comment 10•15 years ago
|
||
Attachment #423308 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #423308 -
Flags: review?(gavin.sharp) → review+
Comment 11•15 years ago
|
||
(In reply to comment #9)
> > Are you saying that we can't make them work?
>
> Custom menuitems would work, as they wouldn't be directly on the toolbar but
> inside the menubar element. But maybe I misunderstand your question...
I meant custom toolbaritems (e.g. a button dragged onto the menubar). Is there something we can do to make them work on auto-hidden menubars (i.e. work around the problem described in comment 7)?
Updated•15 years ago
|
Attachment #385367 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 12•15 years ago
|
||
There's already code in toolbar.xml for making right-clicks on the toolbar work. I suppose this could be extended for other actions, but it won't be pretty.
Assignee | ||
Updated•15 years ago
|
Attachment #385367 -
Attachment is obsolete: true
Assignee | ||
Comment 13•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 14•15 years ago
|
||
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization
this should land on 1.9.2 to fix bug 526460
Attachment #423308 -
Flags: approval1.9.2.1?
Comment 15•15 years ago
|
||
Dao, I would like to at a Litmus test for that. It would be great to know which possible paths we have to take to test the menu bar auto-hiding after a customization.
Flags: in-litmus?
Assignee | ||
Comment 16•15 years ago
|
||
(In reply to comment #15)
> It would be great to know which
> possible paths we have to take to test the menu bar auto-hiding after a
> customization.
I'm not sure what you mean. If you're asking about ways to enable auto-hiding, then the answer is that there are only two: Unchecking "Menu Bar" in the toolbars' context menu or unchecking it in View -> Toolbars. They both do the same and don't need to be tested separately.
Comment 17•15 years ago
|
||
No, I'm talking about which customizations have to be made to see the behavior of that bug. If you have a fresh profile created with 3.6 is it enough to move only one toolbar button to the menu bar? Was that responsible for the brokenness of the auto-hiding feature?
Assignee | ||
Comment 18•15 years ago
|
||
Any item except for spacers and separators would disable auto-hiding (in new windows or after a restart anyway).
Comment 19•15 years ago
|
||
Any plan to include this in FireFox 3.6.1?
Updated•15 years ago
|
Attachment #423308 -
Flags: approval1.9.2.2? → approval1.9.2.3?
Comment 20•15 years ago
|
||
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization
Moving flag to 1.9.2.3
Comment 21•14 years ago
|
||
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization
Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #423308 -
Flags: approval1.9.2.4?
You need to log in
before you can comment on or make changes to this bug.
Description
•