Closed
Bug 499141
Opened 15 years ago
Closed 15 years ago
[HTML5] Check in the Java to C++ translator
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
It would be convenient to have the Java to C++ translator that is used for generating parts of the HTML5 parser in the tree so that anyone who needs to run it doesn't need to obtain a suitable revision separately.
Checking it in has been OKed by licensing at mozilla.org.
Reporter | ||
Updated•15 years ago
|
Assignee: hsivonen → nobody
Comment 1•15 years ago
|
||
Is there a project name for this? For the moment I think we want an entirely separate repository such as hg.mozilla.org/html5parser.
If you like we can look at importing the history from subversion... the convert tool should do this without problems.
Comment 2•15 years ago
|
||
(In reply to comment #1)
> If you like we can look at importing the history from subversion... the convert
> tool should do this without problems.
Indeed it does:
http://hg.mozilla.org/users/bnewman_mozilla.com/html5parser/
Comment 3•15 years ago
|
||
When/if Henri switches to Mercurial, we can simply update parser/html/java/htmlparser/Makefile.
Also updated the license blocks to list me as a contributor instead of the initial developer.
Attachment #388568 -
Flags: superreview?(jst)
Attachment #388568 -
Flags: review?(jst)
Updated•15 years ago
|
Attachment #388568 -
Flags: superreview?(jst)
Attachment #388568 -
Flags: superreview+
Attachment #388568 -
Flags: review?(jst)
Attachment #388568 -
Flags: review+
Comment 4•15 years ago
|
||
Comment on attachment 388568 [details] [diff] [review]
make targets to update java sources and perform translation
- In parser/html/javasrc:
@@ -0,0 +1,1 @@
+java/htmlparser/src
\ No newline at end of file
Add a newline? :)
Let's get this in to start with, we'll update this once the HTML5 Java source is moved to a new home and tweak as needed when needed.
r+sr=jst
Comment 5•15 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/3c25f8166818
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
Comment on attachment 388568 [details] [diff] [review]
make targets to update java sources and perform translation
>diff --git a/.hgignore b/.hgignore
>+\.class$
This seems like a bad idea in general, given that we have two checked in *.class files (below). Maybe it could be restricted to certain directories?
dom/tests/mochitest/dom-level2-html/files/applets/org/w3c/domts/DOMTSApplet.class
dom/tests/mochitest/dom-level2-html/files/applet2.class
Comment 7•15 years ago
|
||
Based on a brief experiment just now, it appears that .hgignore patterns don't have any bearing on files that've been 'hg add'-ed, meaning that any existing .class files (like these two) are safe. However, I'm more than happy to restrict the pattern to exclude just the files I've knowingly introduced.
Attachment #388769 -
Flags: superreview?(dbaron)
Attachment #388769 -
Flags: review?(dbaron)
Updated•15 years ago
|
Attachment #388769 -
Flags: superreview?(dbaron)
Attachment #388769 -
Flags: review?(dbaron)
Attachment #388769 -
Flags: review+
Comment 8•15 years ago
|
||
This all started when I wanted to change 'make sync' so that it didn't clobber local files. I noticed that I was repeating the same changes in two or three different Makefiles, so I moved the common bits into proper shell scripts.
Attachment #388802 -
Flags: superreview?(jst)
Attachment #388802 -
Flags: review?(jst)
Updated•15 years ago
|
Attachment #388769 -
Flags: superreview?(jst)
Comment 9•15 years ago
|
||
Please file a new bug for followups, this bug is fixed! :)
Updated•15 years ago
|
Attachment #388769 -
Attachment is obsolete: true
Attachment #388769 -
Flags: superreview?(jst)
Comment 10•15 years ago
|
||
Comment on attachment 388802 [details] [diff] [review]
refactor repetitive makefile shell commands into external scripts
Created followup bug 504444.
Attachment #388802 -
Attachment is obsolete: true
Attachment #388802 -
Flags: superreview?(jst)
Attachment #388802 -
Flags: review?(jst)
You need to log in
before you can comment on or make changes to this bug.
Description
•