User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4) Gecko/20090615 Gentoo Firefox/3.5b4 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4) Gecko/20090615 Gentoo Firefox/3.5b4 Using the system-nspr while building firefox-3.5rc1, gives an error about PR_ASSERT_CURRENT_THREAD_IN_MONITOR. This is due to an outdated dependency of nspr, since the in-tree version is 4.8 and defines PR_ASSERT_CURRENT_THREAD_IN_MONITOR in prmon.h Relevant line in configure.in: AM_PATH_NSPR(4.7.0, [MOZ_NATIVE_NSPR=1], [MOZ_NATIVE_NSPR=]) ---- Build error: i686-pc-linux-gnu-g++ -o nsOggDecoder.o -c -I../../../../dist/include/system_wrappers -include ../../../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I. -I. -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/gfx -I../../../../dist/include/content -I../../../../dist/include/thebes -I../../../../dist/include/layout -I../../../../dist/include/widget -I../../../../dist/include/dom -I../../../../dist/include/js -I../../../../dist/include/locale -I../../../../dist/include/unicharutil -I../../../../dist/include/webshell -I../../../../dist/include/uriloader -I../../../../dist/include/htmlparser -I../../../../dist/include/necko -I../../../../dist/include/view -I../../../../dist/include/pref -I../../../../dist/include/docshell -I../../../../dist/include/xpconnect -I../../../../dist/include/xuldoc -I../../../../dist/include/caps -I../../../../dist/include/editor -I../../../../dist/include/imglib2 -I../../../../dist/include/mimetype -I../../../../dist/include/exthandler -I../../../../dist/include/uconv -I../../../../dist/include/intl -I../../../../dist/include/plugin -I../../../../dist/include/cairo -I../../../../dist/include/libpixman -I../../../../dist/include -I../../../../dist/include/content -I/usr/include/nspr -I/var/tmp/portage/net-libs/xulrunner-1.9.1_rc1/work/mozilla-1.9.1/dist/sdk/include -I./../../../base/src -I./../../../html/content/src -fPIC -DGENTOO_NSPLUGINS_DIR=\"/usr/lib/nsplugins\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib/nsbrowser/plugins\" -fno-rtti -fno-handle-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -march=pentium-m -pipe -Wno-return-type -w -fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -DGENTOO_NSPLUGINS_DIR=\"/usr/lib/nsplugins\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib/nsbrowser/plugins\" -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Wp,-MD,.deps/nsOggDecoder.pp nsOggDecoder.cpp nsOggDecoder.cpp: In member function ‘PRBool nsOggDecodeStateMachine::IsBuffering() const’: nsOggDecoder.cpp:368: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘PRBool nsOggDecodeStateMachine::IsSeeking() const’: nsOggDecoder.cpp:375: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘PRBool nsOggStepDecodeEvent::InStopDecodingState()’: nsOggDecoder.cpp:631: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘void nsOggDecodeStateMachine::HandleDecodeErrors(OggPlayErrorCode)’: nsOggDecoder.cpp:738: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘nsOggDecodeStateMachine::FrameData* nsOggDecodeStateMachine::NextFrame()’: nsOggDecoder.cpp:753: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘void nsOggDecodeStateMachine::UpdatePlaybackPosition(float)’: nsOggDecoder.cpp:1116: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope nsOggDecoder.cpp: In member function ‘void nsOggDecodeStateMachine::StopStepDecodeThread(nsAutoMonitor*)’: nsOggDecoder.cpp:1381: error: ‘PR_ASSERT_CURRENT_THREAD_IN_MONITOR’ was not declared in this scope gmake[1]: *** [nsOggDecoder.o] Error 1 gmake[1]: Leaving directory `/var/tmp/portage/net-libs/xulrunner-1.9.1_rc1/work/mozilla-1.9.1/content/media/video/src' make: *** [default] Error 2 Reproducible: Always Steps to Reproduce: 1. Compile with system nspr (4.7) 2. Voila 3. Also, there's no actual release of nspr 4.8 on the website, although the ftp shows a release[1]. Is that the beta? 1. ftp://ftp.mozilla.org/pub/mozilla.org/nspr/releases/v4.8/src/

I confirmed that Firefox 3.5 is not buildable using nspr 4.7.5. Bump the required system nspr version to 4.8.0.

(In reply to comment #1) > Created an attachment (id=383977) [details] > bump system nspr to 4.8.0 > Are you sure that's the right patch? :)

Of course I'm sure the first patch is correct. I would not be attaching the correct file now that bumps the system nspr check to 4.8.0. *wink*

Comment on attachment 384105 [details] [diff] [review] patch [Checkin: Comment 4 & 9] Comment 0 says we need this on the 1.9.1 (Firefox 3.5) branch.

Comment on attachment 384105 [details] [diff] [review] patch [Checkin: Comment 4 & 9] a1912=beltzner

Comment on attachment 384105 [details] [diff] [review] patch [Checkin: Comment 4 & 9] This didn't land in time for 1.9.1.2.

Comment on attachment 384105 [details] [diff] [review] patch [Checkin: Comment 4 & 9] Approved for 1.9.1.4, a=dveditz for release-drivers Let's try to get this one landed this time.

Verified for 1.9.1 in source.