Closed
Bug 499278
Opened 15 years ago
Closed 15 years ago
non-ascii IMAP-folder names appear wrong after rename
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: mozilla, Assigned: Bienvenu)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
standard8
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b4) Gecko/20090427 Fedora/3.5-0.20.beta4.fc11 Firefox/3.5b4
Build Identifier: 3.0b3pre
using Fedora 11-release of 3.0b3pre
Upon renaming inside Thunderbird foldernames appear with specialchars as they are stored on the IMAP-server ("Köln" is "K&APY-ln").
Reproducible: Always
Actual Results:
e.g. "Köln" is "K&APY-ln"
Assignee | ||
Comment 1•15 years ago
|
||
Do the names fix themselves when you restart?
Comment 2•15 years ago
|
||
Does the "K&APY-ln" appear at folder pane of Tb?
Or you are talking local file name of "K&APY-ln" which is created/used by Tb?
If former, Bug 450754 is already fixed by Tb 3.0b1...
New problem upon rename which should be listed in Dependency tree for Bug 497199?
What is date of the "Tb 3.0b3pre"?
If latter, read thru Bug 450754, please.
Reporter | ||
Comment 3•15 years ago
|
||
Folders created before / using a different program show up okay.
Folders created with the new thunderbird even appear broken after restart, so I assume they are created wrong on the IMAP-server (worked with TB 2.x).
Current version shipped for Fedora 11 claims to be:
thunderbird-3.0-2.4.b3pre.hg.6a6386c16e98.fc11.x86_64
Comment 4•15 years ago
|
||
Phenomenon was observed with 2009.6.21 build.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090621 Shredder/3.0b3pre
When K&APY-ln was displayed as folder name after rename, name in folder properties was K&APY-ln, but Köln was properly displayed in subscription list.
After two consecutive "collapse/re-expand of IMAP account", Köln was displayed at folder pane. No restart was required.
Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•15 years ago
|
||
I see this.
Flags: blocking-thunderbird3+
Keywords: regression,
regressionwindow-wanted
Summary: IMAP-foldernames with specialchars appear wrong → non-ascii IMAP-folder names appear wrong after rename
Target Milestone: --- → Thunderbird 3.0b3
Assignee | ||
Comment 6•15 years ago
|
||
taking - I'll try to reproduce this
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•15 years ago
|
||
yes, ok, we're not converting back from imap-mod utf7 on rename.
We are doing it correctly on new folder creation, so this bug is a little less serious than I thought...
Assignee | ||
Comment 8•15 years ago
|
||
the new name is in imap mod-utf7, so convert it correctly to unicode.
If I had to guess, I would guess this broke way early in the 3.0 process, probably when we got rid of nsFileSpec, or perhaps did some of the string reworking.
Attachment #385435 -
Flags: superreview?(bugzilla)
Attachment #385435 -
Flags: review?(bugzilla)
Comment 9•15 years ago
|
||
Comment on attachment 385435 [details] [diff] [review]
trivial fix
>- CopyASCIItoUTF16(newName, newNameString);
>+ nsCString utf7LeafName;
>+ rv = CopyMUTF7toUTF16(PromiseFlatCString(newName), newNameString);
>+ NS_ENSURE_SUCCESS(rv, rv);
You're not using utf7LeafName. r/sr=Standard8 with that removed. A unit test would be nice, but not needed for getting this patch in.
Attachment #385435 -
Flags: superreview?(bugzilla)
Attachment #385435 -
Flags: superreview+
Attachment #385435 -
Flags: review?(bugzilla)
Attachment #385435 -
Flags: review+
Updated•15 years ago
|
Flags: in-testsuite?
Keywords: regressionwindow-wanted
Assignee | ||
Comment 10•15 years ago
|
||
fix checked in, with nit addressed. Yes, a unit test of all of our imap mod utf7 handling would be a good thing.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•