Closed Bug 499640 Opened 15 years ago Closed 4 years ago

Allow users to print non-contiguous page ranges (using commas and dashes)

Categories

(Toolkit :: Printing, enhancement, P1)

Product:
Toolkit
Component:
Printing
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- verified
firefox86 --- verified

People

(Reporter: box, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v85][old-ui-])

Attachments

(1 file)

Bug 499640: add frontend support for non-contiguous page ranges
(deleted), text/x-phabricator-request
Details
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 2.0.50727) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 2.0.50727) At the Print menu one can only select a Print Range of pages to print (say pages 1 - 3 --> 1, 2 and 3), but it's not possible to enter page numbers directly (say pages 1, 3 --> 1 and 3). Reproducible: Always Steps to Reproduce: 1. File -> Print 2. See the Print Range section Actual Results: Only able to select a continuous range of page numbers. Expected Results: Able to insert separate page numbers to print.
Version: unspecified → 3.0 Branch
This bug also can be reproduced on: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.1.8) Gecko/20100222 Firefox/3.5.8
Status: UNCONFIRMED → NEW
Ever confirmed: true
This should be a bug not enhancement. On GNOME, the tooltip suggests "comma" is supported. "Specify one or more page ranges, e.g. 1-3,7,11"
Severity: enhancement → normal
OS: Windows Server 2003 → All
Hardware: x86 → All
Sorry, it should be enhancement for Windows and Mac OS X. There's no way to input comma in page ranges on these platforms. But for Linux and Solaris, the dialog suggests it can use comma. So Bug 558742 is not a dupe of this one.
Severity: normal → enhancement
Hi, I can confirm this bug. (See also https://bugzilla.redhat.com/show_bug.cgi?id=672860.) Would be great if this bug could be “killed” because it is somewhat of an annoying bug (especially if you would like to save paper and ink).
Component: General → Printing: Setup
Product: Firefox → Core
QA Contact: general → printing.setup
Version: 3.0 Branch → 1.9.0 Branch
Version: 1.9.0 Branch → unspecified
Is this a MS/Mac only “enhancement” bug report? Can the two problems (“enhancement” for MS/Mac and “bug” for Linux) only be solved separately? If so, my comment does not concern this report but bug 558742, which is marked as duplicate of this bug. The situation with these two bug reports is not very clear to me …
Its possible its still a dupe, If the code is not platform dependent. But we'll probably have to let the developers decide.
This probably not a dupe because the print dialog on Win/Mac, you have no place to input comma. So, on Win/Mac, we need a separate bug to improve the dialog.
Whiteboard: [print2020]

Marking this as P1 for now, since telemetry shows that the page range settings are the settings that users adjust the most.

Also moving to Toolkit. We can have bug 1661868 as the bug to cover the platform work.

Component: Printing: Setup → Printing
Depends on: 1661868
Priority: -- → P1
Product: Core → Toolkit
Summary: Print Range - Pages: Can't select comma separated page numbers to print → Allow users to print non-contiguous page ranges (using commas and dashes)
Whiteboard: [print2020] → [print2020_v83][old-ui-]
Depends on: 1669854

(In reply to Jonathan Watt [:jwatt] from comment #9)

Also moving to Toolkit. We can have bug 1661868 as the bug to cover the platform work.

Some additional platform work (providing an API) will come in bug 1661868.

Also, I believe we're targeting 84 for this now --> adjusting whiteboard accordingly.

Whiteboard: [print2020_v83][old-ui-] → [print2020_v84][old-ui-]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED

A comma will separate the list of ranges, and a dash indicates a page range.

This patch is a WIP and here are things that are lacking:

  1. When selected, the page input does not show the large red border (only when
    unselected)
  2. Hover over errors are currently the custom validity messages.
  3. This does not send the updates to the platform code. There is a platform
    bug blocking this, but we need to understand what sort of data the platform team
    expects.
  4. Need to do a sweep through the test suite to see if this affects other tests.

I have always used semicolons instead of commas. That is supported by the native GTK print dialog.

Moving to 85, as this requires string changes and potentially a platform fix (Bug 1679706)

Whiteboard: [print2020_v84][old-ui-] → [print2020_v85][old-ui-]
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7079a38f0bc8 add frontend support for non-contiguous page ranges r=mstriemer,fluent-reviewers
Regressions: 1681226

https://hg.mozilla.org/mozilla-central/rev/7079a38f0bc8

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Flags: qe-verify+

Verified the fix using latest Nightly 86.0a1 and Firefox 85.0b2 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The pages can be inserted and printed separately.

Status: RESOLVED → VERIFIED
status-firefox85: fixed → verified
status-firefox86: --- → verified
Flags: qe-verify+
Regressions: 1684952

I am not sure if :emilio's update

Regressions: 1684952

addresses this, but the person who implemented the fix accidentally introduced Bug #1684952, which, while arguably not a defect, confuses the user and removes the option to print more sophisticated materials.

To whoever implemented the fix (:emalysz?), please review Bug #1684952 and consider fixing it (should be easy, just removing "redundant" code).

Sorry if this is a duplicate of :emilio's update above, I am not familiar with regressions.

Blocks: 1684952
No longer regressions: 1684952
Regressions: 1685823
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: