STR: 1. have an offline-allowed web application that stores some data to localStorage 2. open the "Clear recent History" dialog, switch to "Everything" and check only "Cache" 3. localStorages for all offline-allowed web applications get cleared Expected one of these: a. localStorage is erased when deleting cookies only or better: b. have a new section (check box) for deleting "offline application user data" because the localStorage data stored by an offline app is nigher a cookie nor a cache data; this should also be option for data in a structured database when we introduce it

Bug 398478 caused this.

I think you probably mean that bug 480169 caused this? Bug 398478 added a separate option that's since been removed in that dialog. But I thought we fixed this in bug 497656...

Which build are you testing?

(In reply to comment #2) > I think you probably mean that bug 480169 caused this? No, following hunk added deletion of storage data when deleting offline cache: http://hg.mozilla.org/releases/mozilla-1.9.1/diff/25b6bca5517d/browser/base/content/sanitize.js, it's bug 398478. It's IMHO wrong. > Bug 398478 added a > separate option that's since been removed in that dialog. But I thought we > fixed this in bug 497656... It's about a preference, not about deletion itself. (In reply to comment #3) > Which build are you testing? I am using shiretoko. I think we are missing one more option for "user data" or "offline applications user data". It's missing and it's also said in bug 497656 those options are missing.

So, is there a voice against to fix this bug? Otherwise I take it and start working on it as per the description.

-> me

Jason, do you have any opinion on this?

Johnath and I just looked through the code, and don't see where http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js#171 gets hit unless the preference is set to be true, and as per bug 497656 we don't migrate that preference over and it defaults to false. In other words, I suspect that somehow that preference has been modified on your system, and that this isn't the default behaviour. Can you confirm this with a new profile? If you can't, I suggest we close this as INVALID. If this bug is VALID, then I don't think it blocks. It's unclear to me how users think of localStorage() data; sometimes it's the same as cookies, other times it's meant to be more permanent (like storing bits of the application data). It feels like what you actually want is a spinoff that advocates putting control for clearing offline data back in Clear Recent History, and a discussion about the best UI for that.

> In other words, I suspect that somehow that preference has been modified on > your system, and that this isn't the default behaviour. Can you confirm this > with a new profile? I tested this on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2pre) Gecko/20100106 Namoroka/3.6pre, Mike's right: localStorage is not cleared when only selecting "Cache" in Clear Recent History. I tested both with "offline-allowed web application" (one that uses an offline manifest - http://demos.hacks.mozilla.org/openweb/todo/ ) and a regular page (google). > It feels like what you actually want is a spinoff that advocates putting > control for clearing offline data back in Clear Recent History Filed bug 538595. Resolving this one as invalid.

I'm able to reproduce with Shiretoko, Namoroka and Minefield but only with my profile. Going to investigate. I'm changing the summary. With a clear profile I cannot reproduce.

Got it. I have set a UI-invisible pref privacy.cpd.offlineApps to true. This caused DOM storage be clear even there would be no option in the dialog selected. Reclosing.