* Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "um.activeUpdate is null" {file: "file:///c:/moz/_1_mozilla-central/ff-debug/dist/bin/components/nsUpdateService.js" line: 2734}]' when calling method: [nsIRequestObserver::onStopRequest]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes]

Comment on attachment 384468 [details] [diff] [review] patch rev1 with tests By directly calling xpcom-shutdown this tests this in every test

Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/7a8502b70fdf

Comment on attachment 384689 [details] [diff] [review] patch as checked in Drivers, this is a safe, sane, simple fix with tests for an edgecase where the update manager throws during onStopRequest for nsIIncrementalDownload. I'd like to get this for 1.9.1 if there is another RC

Won't block on this, but feel free to request approval1.9.1.1 on the patch (though we might punt until 1.9.1.2 given how small this release is intended to be).

Comment on attachment 384689 [details] [diff] [review] patch as checked in Requesting 1.9.1.1 - drivers, this is a safe, sane, simple fix with tests for an edgecase where the update manager throws during onStopRequest for nsIIncrementalDownload. I'd like to get this for 1.9.1.1

Comment on attachment 384689 [details] [diff] [review] patch as checked in Should also get this in for 1.9.0.13

Comment on attachment 384689 [details] [diff] [review] patch as checked in Approved for 1.9.0.13, a=dveditz for release-drivers

Checked in for 1.9.0.13 / Firefox 3.0.13 Checking in toolkit/mozapps/update/src/nsUpdateService.js.in; /cvsroot/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in,v <-- nsUpda teService.js.in new revision: 1.155; previous revision: 1.154 done Checking in toolkit/mozapps/update/test/unit/head_update.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/head_update.js,v <-- head_up date.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/mozapps/update/test/unit/tail_update.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/tail_update.js,v <-- tail_up date.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/mozapps/update/test/unit/test_0010_general.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0010_general.js,v <-- t est_0010_general.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/mozapps/update/test/unit/test_0020_general.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0020_general.js,v <-- t est_0020_general.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/mozapps/update/test/unit/test_0030_general.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0030_general.js,v <-- t est_0030_general.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/mozapps/update/test/unit/test_0040_general.js.in; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0040_general.js.in,v <-- test_0040_general.js.in new revision: 1.4; previous revision: 1.3 done Checking in toolkit/mozapps/update/test/unit/test_0060_manager.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0060_manager.js,v <-- t est_0060_manager.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/mozapps/update/test/unit/test_0061_manager.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0061_manager.js,v <-- t est_0061_manager.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/mozapps/update/test/unit/test_0062_manager.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0062_manager.js,v <-- t est_0062_manager.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/mozapps/update/test/unit/test_0110_general.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0110_general.js,v <-- t est_0110_general.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/mozapps/update/test/unit/test_0111_general.js; /cvsroot/mozilla/toolkit/mozapps/update/test/unit/test_0111_general.js,v <-- t est_0111_general.js new revision: 1.2; previous revision: 1.1 done

Comment on attachment 384689 [details] [diff] [review] patch as checked in Approved for 1.9.1.2. a=ss for release-drivers Please land on mozilla-1.9.1 and use the ".2-fixed" option of the "status1.9.1" flag.

Pushed to mozilla-1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8544fcde14a2

Robert, could you help us verify this for 3.5.2, or add a comment to that extent?

There aren't steps where you can reproduce this but it does have a test. If you like I can show you the change via an xpcshell test with / without the patch but that seems a bit overkill for what the patch does which is add a null check

Verified for 1.9.0.14 based on tests passing.