Closed Bug 500004 Opened 15 years ago Closed 15 years ago

drag of message from Search Messages fails with error "GetSelectedMessages is not defined" messengerdnd.js Line: 452

Categories

(MailNews Core :: Search, defect)

Product:
MailNews Core
Component:
Search
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Thunderbird 3.0b4

People

(Reporter: wsmwk, Assigned: rain1)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

proper fix
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
Error: GetSelectedMessages is not defined Source File: chrome://messenger/content/messengerdnd.js Line: 452 Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090621 Shredder/3.0b3pre
Blocks: gloda-ui-regressions
OS: Windows Vista → All
Hardware: x86 → All
Attached patch possible fix (obsolete) (deleted) — — Splinter Review
<http://mxr.mozilla.org/comm-central/source/mail/base/content/SearchDialog.js#567> says we don't support drag and drop in the thread pane. Is there a reason to keep messengerdnd.js? I'd also like to either move messengerdnd.js to suite or get rid of it completely, but this is what I quickly came up with.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #386129 - Flags: review?(mkmelin+mozilla)
That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... Yeah thunderbird should get rid of messengerdnd.js.
(In reply to comment #1) > Created an attachment (id=386129) [details] > possible fix "possible", as in it's not clear this fixes it?
(In reply to comment #2) > That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... > Yeah thunderbird should get rid of messengerdnd.js. so then we won't need to care about bug 456156, bug 446292 and bug 446288?
(In reply to comment #3) > "possible", as in it's not clear this fixes it? As in get's rid of the exception, but dragging doesn't work.
Attachment #386129 - Flags: review?(mkmelin+mozilla) → review-
Comment on attachment 386129 [details] [diff] [review] possible fix Minusing per previous comments.
Flags: blocking-thunderbird3?
Attached patch proper fix (deleted) — — Splinter Review
Straightforward, and works nicely here.
Attachment #386129 - Attachment is obsolete: true
Attachment #399094 - Flags: review?(mkmelin+mozilla)
Comment on attachment 399094 [details] [diff] [review] proper fix yay! r=mkmelin
Attachment #399094 - Flags: review?(mkmelin+mozilla) → review+
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b4
http://hg.mozilla.org/comm-central/rev/9b7f6edb75fa Setting in-testsuite? since I hope we'll cover drag/drop in our test suite at some point in the future.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Filed bug 515397 about not shipping messengerdnd.js with Thunderbird.
v.fixed 20090909 build. yay! again. Thanks sid.
Status: RESOLVED → VERIFIED
Flags: in-litmus?
(In reply to comment #0) Are you sure this is related to (bug 497199 ->) bug 474701? (In reply to comment #2) > That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... You sure? It looks like this occurrence was simply missed in bug 414038 comment 116?!
Blocks: 414038, 510793
I never verified which bug it's related to, but yeah iirc i verified it worked with beta2
Depends on: 500564
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: