Closed Bug 500910 Opened 15 years ago Closed 15 years ago

GTK test plugin should take XShapes into account when computing clip region

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file, 1 obsolete file)

fix v2
(deleted), patch
roc
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) (deleted) — — Splinter Review
When computing the plugin's effective clip region, the test plugin should consider any shape regions set on ancestor windows. We need this so that when we use shapes to clip plugins instead of ancestor widgets, tests still pass.
Attachment #385562 - Flags: review?(mozbugz) → review+
Comment on attachment 385562 [details] [diff] [review] fix -EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) $(XLDFLAGS) $(XLIBS) +EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) $(XLDFLAGS) $(XLIBS) -lXext $(XEXT_LIBS) is available for this.
http://hg.mozilla.org/mozilla-central/rev/91a43fa9b0da
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch fix v2 (deleted) — — Splinter Review
There was a critical missing gdk_intersect_region(region, windowRgn). I'm not sure how that happened, but the tests pass with this version of the patch.
Attachment #388055 - Flags: review+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/f7349b09a8ce
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: