Closed Bug 50142 Opened 24 years ago Closed 23 years ago

[MARGIN-C]collapsing does positive/negative mix wrong

Categories

(Core :: Layout, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: dbaron, Assigned: dbaron)

References

(Depends on 1 open bug)

Details

(Keywords: css1, testcase)

Attachments

(1 file)

DESCRIPTION: A collapsed margin, according to CSS1 http://www.w3.org/TR/REC-CSS1#vertical-formatting or CSS2 http://www.w3.org/TR/REC-CSS2/box.html#collapsing-margins , is the maximum of the positive values plus the minimum of the negative values. We don't do this right, since MaxMargin collapses margins one at a time, which is wrong. I have some of the necessary changes to correct this in my tree. I'm not sure if I'm going to finish or give up - it's a surprisingly large change because of the organization of the block code (which I'm really beginning to hate). STEPS TO REPRODUCE: * look at testcase
Keywords: css1
Attached file testcase (deleted) —
Well, this is fixed in my tree
Assignee: buster → dbaron
Whiteboard: [fix in hand]
Now it's broken again, in weird ways.
I think maybe I've completely stopped pulling out top margins...
Giving margin collapsing bugs that I have not fixed back to buster.
Assignee: dbaron → buster
Whiteboard: [fix in hand]
Depends on: 50959
Keywords: correctness
This is one we just can't get to before RTM. Marking future. Eric: since this is a css1 compliance issue, I thought you should be on the cc-list. Let me know if you disagree with "future" milestone.
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: --- → Future
QA Contact: petersen → chrisd
Keywords: testcase
Upon managerial request, adding the "testcase" keyword to 84 open layout bugs that do not have the "testcase" keyword and yet have an attachement with the word "test" in the description field. Apologies for any mistakes.
Netscape's standard compliance QA team reorganised itself once again, so taking remaining non-tables style bugs. Sorry about the spam. I tried to get this done directly at the database level, but apparently that is "not easy because of the shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
Taking, since my changes on bug 86947 fix this.
Assignee: buster → dbaron
Status: ASSIGNED → NEW
Depends on: 86947
Target Milestone: Future → mozilla0.9.5
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Fixed by checkin of bug 86947 at 2001-10-24 18:08 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: