Closed
Bug 502103
Opened 15 years ago
Closed 15 years ago
Crash [@ NS_NewEditorKeyListener] with <isindex action="">
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: hsivonen)
References
Details
(Keywords: crash, testcase)
Crash Data
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
See testcase, which crashes current trunk build when you have the html5.enable pref set to true.
http://crash-stats.mozilla.com/report/index/5619793a-b24e-4818-999e-05d5a2090702
0 kernel32.dll kernel32.dll@0x12afb
1 mozcrt19.dll _CxxThrowException throw.cpp:159
2 mozcrt19.dll operator new obj-firefox/memory/jemalloc/crtsrc/new.cpp:57
3 xul.dll NS_NewEditorKeyListener editor/libeditor/text/nsEditorEventListeners.cpp:888
4 xul.dll nsPlaintextEditor::CreateEventListeners editor/libeditor/text/nsPlaintextEditor.cpp:305
5 xul.dll nsEditor::PostCreate editor/libeditor/base/nsEditor.cpp:295
6 xul.dll nsTextControlFrame::InitEditor layout/forms/nsTextControlFrame.cpp:1583
7 xul.dll nsTextControlFrame::DelayedEditorInit layout/forms/nsTextControlFrame.cpp:1357
|
Assignee | |
Comment 1•15 years ago
|
||
Looks like the isindex attribute adoption code does some bad string releasing.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•15 years ago
|
||
The tree builder was incorrectly treating action as an attribute that doesn't get adopted by another attribute holder even though it does. It would double-released.
Attachment #386721 -
Flags: superreview?(mrbkap)
Attachment #386721 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Unblocking the landing bug, since the landing already happened. (This can be considered to block turning it on by default, though.)
No longer blocks: html5-parsing-land
|
||
Updated•15 years ago
|
Attachment #386721 -
Flags: superreview?(mrbkap)
Attachment #386721 -
Flags: superreview+
Attachment #386721 -
Flags: review?(jonas)
Attachment #386721 -
Flags: review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Flags: in-testsuite?
|
||
Updated•13 years ago
|
Crash Signature: [@ NS_NewEditorKeyListener]
|
||
Comment 5•12 years ago
|
||
Flags: in-testsuite? → in-testsuite+
|
||
Comment 6•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•