Closed
Bug 502333
Opened 15 years ago
Closed 15 years ago
Pre-installed search plugin for Wikipedia (de) in Firefox 3.5 is outdated
Categories
(Mozilla Localizations :: de / German, defect)
Mozilla Localizations
de / German
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: syryos, Unassigned)
References
()
Details
(Keywords: productization)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1) Gecko/20090624 Firefox/3.5
The search plugin for Wikipedia (de) in Firefox 3.5 is outdated, the rolled-out xml file does not support suggestions from Wikipedia (de).
The correct plugin syntax for Wikipedia (de) can be found in the opensearch description file http://de.wikipedia.org/w/opensearch_desc.php [1].
Please update the Firefox ../searchplugin/wikipedia-de.xml with the content corresponding to [1].
Other wikipedia language version need probably also be checked for that problem.
Reproducible: Always
See also bug 502332 - Pre-distributed search engines (search plugin) cannot be updated. e.g. Wikipedia (de).
Updated•15 years ago
|
Component: General → de / German
Product: Firefox → Mozilla Localizations
QA Contact: general → german.de
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Comment 2•15 years ago
|
||
Comment 3•15 years ago
|
||
Comment on attachment 386857 [details]
updated wikipedia-de.xml
Axel, can I check this in or do I need any special permission?
Attachment #386857 -
Flags: review?(l10n)
Comment 4•15 years ago
|
||
Comment on attachment 386857 [details]
updated wikipedia-de.xml
Searchplugins need review before landing. In general, from stas these days.
Can you attach a diff for review instead of a full plugin? Thanks.
Attachment #386857 -
Flags: review?(l10n) → review?(stas)
Comment 5•15 years ago
|
||
Attachment #386857 -
Attachment is obsolete: true
Attachment #389410 -
Flags: review?(stas)
Attachment #386857 -
Flags: review?(stas)
Comment 6•15 years ago
|
||
Stas, could you have a quick look at this? We would like to have this in before 3.5.2 is activated for all users of Firefox 3.0. It's essentially the en-US plugin with "en"s exchanged for "de"s.
Updated•15 years ago
|
Keywords: productization
Comment 7•15 years ago
|
||
Comment on attachment 389410 [details] [diff] [review]
patch
Good catch and a good patch. r=me.
Please land it on mozilla-1.9.1 and l10n-central. Please use a descriptive commit message, e.g. "Bug 502333: Pre-installed search plugin for Wikipedia (de) in Firefox 3.5 is outdated, p=rockmfr@gmail.com, r=stas".
For mozilla-1.9.1: when the patch lands, please test the search plugin and if it's OK, please reply in the current opt-in thread in mozilla.dev.l10n <http://groups.google.com/group/mozilla.dev.l10n/browse_frm/thread/4b9ad68b32106157> with the new revision number. If Axel approves it and the fix makes it to 3.5.3, please set the status1.9.1 flag to .3-fixed. (3.5.3 code freeze is on Tuesday.)
For l10n-central: when the patch lands there, feel free to mark this bug as fixed.
Thanks.
Attachment #389410 -
Flags: review?(stas) → review+
Comment 8•15 years ago
|
||
Thanks, Stas! Checked-in on 1.9.1 with:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/de/rev/56e1a358578e
and on l10n-central with:
http://hg.mozilla.org/l10n-central/de/rev/aa553c16c625
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•