Closed
Bug 503141
Opened 16 years ago
Closed 15 years ago
well-traced peacekeeper array benchmarks are gated by allocation and js_BoxDouble
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
screenshot of system malloc, accompanying locking
Some of the ones we do really well on are gated by malloc/js_NewGCThing/js_NewUninitializedArray
|
Reporter | |
Comment 1•16 years ago
|
||
|
|
Reporter | |
Comment 2•16 years ago
|
||
|
|
Reporter | |
Updated•16 years ago
|
Blocks: peacekeeper
|
||
Comment 3•16 years ago
|
||
I did some perf analysis of this on the flight back. I will write up my results. I have a bunch of patches, but a lot more work remains to be done.
|
|
Reporter | |
Updated•16 years ago
|
Summary: well-traced peacekeeper array benchmarks are gated by allocation → well-traced peacekeeper array benchmarks are gated by allocation and js_BoxDouble
|
|
||
Comment 4•16 years ago
|
||
|
|
Reporter | |
Comment 5•16 years ago
|
||
Comment on attachment 387524 [details] [diff] [review]
patch
this is a good quick proof. I see about 10% faster on my box. Cleaned up patch should go in 503160.
|
||
Comment 6•15 years ago
|
||
/me still wishes for widen and narrow instead of promote and demote
/be
|
||
Comment 7•15 years ago
|
||
This should be fixed by the fatval stuff, right?
|
|
||
Comment 8•15 years ago
|
||
(In reply to comment #7)
> This should be fixed by the fatval stuff, right?
I don't think so. Having said that, looks like this went in with bug 503160, so I'll close. Please reopen if you disagree.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 9•15 years ago
|
||
(In reply to comment #8)
> (In reply to comment #7)
> > This should be fixed by the fatval stuff, right?
>
> I don't think so. Having said that, looks like this went in with bug 503160,
> so I'll close. Please reopen if you disagree.
For the record, I just tested with fatvals and saw no change.
You need to log in
before you can comment on or make changes to this bug.
Description
•