we should implement geolocation addresses based on the Gear's Address object.

Marking wanted, but don't know if we'd block. What does this get us?

in addition to getting a lat/long, you can also get this: where |a| is the objection returned to the geolocation APIs: a.address.streetNumber a.address.street a.address.premises a.address.city a.address.county a.address.region a.address.county a.address.countryCode a.address.postalCode

Is this in a spec somewhere, or is this still being ironed out etc?

This is still being ironed out. The last reasonable format for a simplified address as basically the above plus an extra field called "additionalInformation". I am leaving this field off for now. If there this does become a recommendation, we can append the field. fwiw, google chrome and android use the above address object.

Looks like this may be causing some mochitest failures on mozilla-central (on Mac OS X, so far).

I backed this out for causing mochitest timeouts on all platforms: http://hg.mozilla.org/mozilla-central/rev/191ef763e892 http://hg.mozilla.org/mozilla-central/rev/df6b05ee9830

Should be re-opened?

the failure was caused by our test cases not providing an address response. GLS and other providers should provide this. I tweaked our code to test the response before assuming it is there. In bug 482260, we will update the testing code so that we can test with and without a provider sending an address location.

Doug: I believe you want this in Firefox 3.5. If that's right, please request approval1.9.1.2 on the patch (after checking that it applies). (Note: You have some approval1.9.1.1 requests out. We'll be triaging those, no need to change them to approval1.9.1.2.)

Comment on attachment 388300 [details] [diff] [review] patch v.1 Not for 1.9.1.2.

Comment on attachment 388300 [details] [diff] [review] patch v.1 New features/interfaces are generally not appropriate for the stable branch. 1.9.1 approval denied.

Now documented for Gecko 1.9.2: https://developer.mozilla.org/en/XPCOM_Interface_Reference/NsIDOMGeoPosition https://developer.mozilla.org/en/nsIDOMGeoPositionAddress (the latter will move soon, got put in the wrong place, but there'll be a redirect).