Closed
Bug 504750
Opened 15 years ago
Closed 15 years ago
Add splashscreen support to build system, Firefox part
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
(Whiteboard: [nv])
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
beltzner
:
ui-review+
|
Details | Diff | Splinter Review |
Bug 481494 added optional support for splash screens on slow devices, but didn't integrate with the build system for shipping the bitmap used.
This patch adds support for a splash.bmp in the build system that's used when a splashscreen is enabled. Bug 502526 will update the splash screens with polished artwork, this patch just includes the Firefox-branded splash vlad made (attached in 502526), and a couple placeholders for the unbranded and nightly branding.
Assignee | ||
Comment 1•15 years ago
|
||
Now with more splash.
Attachment #389087 -
Flags: review?(benjamin)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [nv]
Comment 2•15 years ago
|
||
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]
We shouldn't ever be shipping Firefox with a splash screen, just Fennec. Splash screen is disabled by default, and mobile has to explicitly enable it, right?
Attachment #389087 -
Flags: review?(benjamin) → review-
Assignee | ||
Updated•15 years ago
|
Attachment #389087 -
Flags: review- → review?(benjamin)
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]
As mentioned on IRC... We actually will be shipping Firefox (not Fennec) with a splashscreen for Windows CE. These will be different builds, including (among other tweaks) --enable-splashscreen.
Normal Windows (XP/Vista/etc) builds won't be affected, and will not have a splashscreen.
Comment 4•15 years ago
|
||
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]
ok, with beltzner's approval
Attachment #389087 -
Flags: ui-review?(beltzner)
Attachment #389087 -
Flags: review?(benjamin)
Attachment #389087 -
Flags: review+
Updated•15 years ago
|
Attachment #389087 -
Flags: ui-review?(beltzner) → ui-review+
Assignee | ||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Updated•15 years ago
|
Summary: Add splashscreen support to build system → Add splashscreen support to build system, Firefox part
Updated•15 years ago
|
Attachment #389087 -
Attachment description: Patch v.1 → Patch v.1
[Checkin: Comment 5]
You need to log in
before you can comment on or make changes to this bug.
Description
•