Libpng-1.2.38 has been released. It's mostly cosmetic, but for mozilla it provides defense against bad iCCP chunks when color management is not being used.

Comment on attachment 389118 [details] [diff] [review] Update libpng in trunk to version 1.2.38 (v0) No sr required under the new SR rules: http://www.mozilla.org/hacking/reviewers.html

I've tried this patch for my build (Mac OS X 10.5.7, Intel), but I get this error.

Comment on attachment 389118 [details] [diff] [review] Update libpng in trunk to version 1.2.38 (v0) I botched the merge of png.h from libpng-1.2.38 with the APNG support. Will try again today.

Fixed merge of png.h with APNG stuff.

Glenn, have you tested APNGs with this patch? I just see a lot of removal of APNG support.

Most of the APNG stuff already in the trunk is not touched. Some #defines are relocated in pngconf.h, and there's a little change involving BLEND_OP included in the libpng patch. No, I have not tested because I don't have access to the try-server and firefox won't build (patched or not) on platforms I have access to. I have to rely on someone who does have access to the try-server for testing.

Glenn - I filed bug 505757 to get you tryserver access. ;-)

And I've pushed v1 to try :)

Lots of build failures. :( http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTry

(In reply to comment #10) > Lots of build failures. :( Do you have log files I can look at? Meanwhile I think I can work out a local testing method for APNG-enabled libpng, but give me a few days.

(In reply to comment #10) > Lots of build failures. :( > http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTry There was a mixup, png.h was from libpng-1.2.37 instead of libpng-1.2.38.

Libpng-1.2.39 has been released. Here is the update to 1.2.39 from 1.2.35, which is what is in the trunk.

Removed a stray "*/" from pngset.c

Relocated a misplaced #define in pngconf.h and fixed a typo in mozpngconf.h

Relocated a misplaced #endif.

Comment on attachment 394800 [details] [diff] [review] Update libpng in trunk to version 1.2.39 (v3) The merge with png.h from libpng-1.2.39 is still not quite right. Cancelling request for review.

This patch corrects the merging of png.h with libpng-1.2.39, and relocates the acTL chunk in output PNG files immediately after the IHDR chunk so APNG files can be quickly recognized.

The v4 patch left some litter, an unwanted working file (png.h_diff). It's removed from v5.

Before I review this, can you post it to the try server to ensure that everything is good?

(In reply to comment #20) > Before I review this, can you post it to the try server to ensure that > everything is good? Yes, I can. The one I put in this morning did not go well, so I've got to check the logs now...

Try Server builds are at https://build.mozilla.org/tryserver-builds/glennrp@gmail.com-v6/

Libpng-1.2.40 is out. The differences from 1.2.39 are trivial.

Successful tryserver builds for the v7 patch are at https://build.mozilla.org/tryserver-builds/glennrp@gmail.com-libpng-1.2.40-v7/

Comment on attachment 400070 [details] [diff] [review] Update libpng in trunk to version 1.2.40 (v7) Checkin of bug #435296 has cause a little bit-rot. I'm testing a v8 patch now.

Fixed bit-rot in nsPNGDecoder.cpp Successful TryServer results are at http://build.mozilla.org/tryserver-builds/glennrp@gmail.com-bug504805-libpng-1.2.40-v8

Joe, ping?

Glenn, I never checked -- did this pass all the unittests on tryserver?

@joe, there are a few sporadic warnings, but I get them whether I apply the patch or not, and they don't show up on all platforms. I don't know how to relate them to anything.

Generally, if you do a search for the failure you see, and you see a bug open about it, it can safely be ignored as "not impacted by this code." (i.e., it's a known intermittent failure.) Those bugs are all tagged with [orange] in the whiteboard, so doing a search for that will show the list of bugs.

New TryServer builds are at https://build.mozilla.org/tryserver-builds/glennrp@gmail.com-bug504805-bug517713-repeat/ There are still several sporadic unittest warnings that seem unrelated to this patch (they sometimes appear, whether or not the patch is applied). As you can probably guess from the URL, I also applied the patch from bug #517713 to these builds.

In order to spark interest to this forgotten bug, here's some tests: http://img18.imageshack.us/img18/6787/mode0milk.png http://img10.imageshack.us/img10/233/mode2gold.png http://img132.imageshack.us/img132/4329/mode3comm.png http://img132.imageshack.us/img132/4936/mode6gears.png Currently Firefox fails all of them.

Comment on attachment 400420 [details] [diff] [review] Update libpng in trunk to version 1.2.40 (v8) Semi-reviewed, mostly rubber-stamp. Sorry it took so long. Glenn: Can you do me one more favour and make sure this still applies to mozilla-central? I'll then commit it.

Joe: OK, I've submitted a tryserver run that tests both this and my patch for bug #517713.

New successful tryserver builds from mozilla-central checked out at 1600 EST today are at https://build.mozilla.org/tryserver-builds/glennrp@gmail.com-504805-v8-517713-v2-10Nov/ The unit tests seem to be failing for reasons unrelated to this patch (the previous run by another user is showing the same failures).

So there were no changes required to attachment 400420 [details] [diff] [review] to make it apply to mozilla-central? (If there were, can you please attach a new version?)

Right, I used the "v8" patch (attachment #400420 [details] [diff] [review]) along with the "v2" patch from bug #517713.

Patch applied without issue. I left bug 517713 to itself, as that patch has not been reviewed yet. http://hg.mozilla.org/mozilla-central/rev/2253ef0bcfca

Comment on attachment 400420 [details] [diff] [review] Update libpng in trunk to version 1.2.40 (v8) This fixes a number of other PNG/APNG-related bugs, so would be good to have on 1.9.2.

I cannot disagree more strenuously. 1.9.2 should be on the path to completion, not unnecessary code churn. If there are specific bugs this fixes that we'd rather not ship with 1.9.2, then let's create separate bugs, with separate, contained, fixes for them.

Comment on attachment 400420 [details] [diff] [review] Update libpng in trunk to version 1.2.40 (v8) Very well. I will nom patches from other bugs.

All four tests from comment #32 work fine in Minefield now.

(In reply to comment #42) > All four tests from comment #32 work fine in Minefield now. Yes, they work for me now as well, on WinXP. Marking VERIFIED.

The tests from comment #32 all fail on Firefox 3.9.3 which was just now pushed with Ubuntu 10.4 (Gecko/20100423).