Closed
Bug 505823
Opened 15 years ago
Closed 11 years ago
nsNSSComponent methods pass nsAutoString's as arguments by value
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
INVALID
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, Whiteboard: [psm-logic])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
line 174 -- NS_IMETHOD DownloadCRLDirectly(nsAutoString, nsAutoString) = 0; String should be passed by reference
PSMContentDownloader::setCrlAutodownloadKey http://mxr.mozilla.org/mozilla-central/ident?i=setCrlAutodownloadKey nsNSSComponent::RemoveCrlFromList http://mxr.mozilla.org/mozilla-central/ident?i=nsNSSComponent::RemoveCrlFromList
Summary: nsNSSComponent::DownloadCRLDirectly passes to 148 byte arguments by value → nsNSSComponent methods pass nsAutoString's as arguments by value
|
||
Updated•14 years ago
|
Whiteboard: [psm-logic]
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 390183 [details] [diff] [review] patch bitrot
Attachment #390183 -
Flags: review?(kaie) → review-
Kaie - I'm trying to get more involved with PSM/NSS, and I thought unbitrotting this patch might be a good start. Do you have time to take a look at this? Thanks.
Attachment #390183 -
Attachment is obsolete: true
Attachment #708204 -
Flags: review?(kaie)
Looks like this was obviated by bug 867465.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Attachment #708204 -
Flags: review?(kaie)
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•