Closed Bug 505892 Opened 15 years ago Closed 7 years ago

malloc_init_hard does not unlock init_lock if MALLOC_VALIDATE and malloc_rtree_new fails

Categories

(Core :: Memory Allocator, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, hang)

Attachments

(1 file)

5530 malloc_init_hard(void) 5541 malloc_mutex_lock(&init_lock); 5550 malloc_mutex_unlock(&init_lock); 5552 return (false); 6020 malloc_mutex_unlock(&init_lock); 6022 return (true); 6037 malloc_mutex_unlock(&init_lock); 6039 return (true); 6065 chunk_rtree = malloc_rtree_new((SIZEOF_PTR << 3) - opt_chunk_2pow); 6066 if (chunk_rtree == NULL) 6067 return (true); 6093 malloc_mutex_unlock(&init_lock); 6095 return (false); 6096 }
Attached patch untested (deleted) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390300 - Flags: review?(jasone)
Attachment #390300 - Flags: review?(jasone)
This was fixed with RAII for locks in bug 1411084.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: