Closed
Bug 506001
Opened 15 years ago
Closed 15 years ago
[Port Bug 505700] Don't allow moving the window with the toolbar while in fullscreen mode.
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b2
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
stefanh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Mnyromyr thinks we should also do this. CC stefanh to confirm since this is OSX specific.
|
Assignee | |
Comment 1•15 years ago
|
||
Toolkit does this:
>- return !this.parentNode.customizing; // Don't move while customizing.
>+ // Don't move while customizing or while in full screen mode.
>+ return !this.parentNode.customizing && !window.fullScreen;
I did it this way instead so that it matches the comment.
+ return !(this.parentNode.customizing || window.fullScreen);
Attachment #390226 -
Flags: superreview?(neil)
Attachment #390226 -
Flags: review?(neil)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]
switching review to stefanh since he has a Mac and I don't
Attachment #390226 -
Flags: review?(neil) → review?(stefanh)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]
Nit: wrong amount of indent on the comment.
Attachment #390226 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 4•15 years ago
|
||
> Nit: wrong amount of indent on the comment.
Fixed locally. Now all I need is for someone to test this on a Mac.
|
||
Comment 5•15 years ago
|
||
AFAIK this will only work if you add ui for it and pull with a mozilla-central tree.
|
|
||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> AFAIK this will only work if you add ui for it and pull with a mozilla-central
> tree.
(By "this" I mean full screen mode)
|
|
Assignee | |
Comment 7•15 years ago
|
||
> AFAIK this will only work if you add ui for it and pull with a mozilla-central
> tree.
But it does no harm to do this now least we forget when we eventually move to 1.9.{2|3|4}, right?
|
|
||
Comment 8•15 years ago
|
||
(In reply to comment #7)
> > AFAIK this will only work if you add ui for it and pull with a mozilla-central
> > tree.
> But it does no harm to do this now least we forget when we eventually move to
> 1.9.{2|3|4}, right?
Sure. I just wanted to explain that even though the patch is really simple it'll take some time before I've tested this. I'll need fullscreen ui for mac and then a tree with m-c.
|
|
||
Updated•15 years ago
|
Attachment #390226 -
Flags: review?(stefanh) → review+
|
|
||
Comment 9•15 years ago
|
||
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]
Wasn't that difficult to test as I thought ;-)
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 10•15 years ago
|
||
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]
http://hg.mozilla.org/comm-central/rev/6c76d904691b
Attachment #390226 -
Attachment description: Patch v1.0 → Patch v1.0
[Checkin: Comment 10]
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•