MozillaBuild 1.4RC2, Vista x64 From the MozillaBuild environment: $ install bash": /c/mozilla-build/vim/vim72/install: Bad file number This rogue install.exe (without manifest) is clearly taking precedence over msys/bin/install.exe in PATH.

Hm, bummer, I didn't notice that there was one in the vim directory. Do we actually use install.exe for anything in the build process on Windows?

Actually they are nsinstall (at least on Win32) http://mxr.mozilla.org/mozilla-central/search?string=^install+*%3D&regexp=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Yeah, "install" is generally only used for installing things system-wide. I don't think we do that on Windows, so I don't think this is critical.

Apparently we use it in the bits of the build system that handle WIN32_REDIST_DIR, so this does break something. :-(

"install" was called directly here :( http://mxr.mozilla.org/mozilla-central/source/build/win32/Makefile.in#73

As a workaround, just delete that install.exe from the VIM folder for now. That's probably what I will do to fix this in MozillaBuild.

I just renamed it to vim-install.exe

Actually I suspect renaming the file and adding a README_mozilla-build.txt file explaining that the file was renamed and why might be better. Distributing the package without the file probably violates the license for distribution.

(In reply to comment #10) > Actually I suspect renaming the file and adding a README_mozilla-build.txt file > explaining that the file was renamed and why might be better. > Distributing the package without the file probably violates the license for > distribution. The Vim license is quite generous, see ":help license" in a running Vim. Alternately, putting the Vim install executable sufficiently "late" in the $PATH might be enough... provided you make sure that you always call _that_ install.exe either with a full path or (on Window) after cd to its directory. I believe this is a reasonable assumption.

(In reply to comment #7) > "install" was called directly here :( > http://mxr.mozilla.org/mozilla-central/source/build/win32/Makefile.in#73 Shouldn't that actually call $(NSINSTALL) or $(SYSINSTALL) instead?

Since Songbird actually uses install.exe to copy files around, this turns out to be important for us :) This just puts vim later in the path; assuming you don't have vim.exe / gvim.exe earlier (e.g. in /bin), that should be fine. My install of MozillaBuild (stock) doesn't, at least :D Note that, in reading the vim license, it says something about having to note in :version that vim has been modified. That seems kinda hard for deleting a file, so I decided against doing that :) I don't know why, but . appears in my path. That means running `install` when cwd is /c/mozilla-build/vim/vim72 will still use the vim version. I don't think I care about that case ;)

Fixed in http://hg.mozilla.org/mozilla-build/rev/224a69b28acf (moved PATH order around) then forgotten for about a week :( sorry.