Closed
Bug 506201
Opened 15 years ago
Closed 15 years ago
regexp.cpp fails to compile on opensolaris: goto bypasses variable init
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Mardak, Assigned: leon.sha)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/b837948c1daf#l1.1139
1.1140 goto out;
1.1141 }
1.1142 rv = rc.compile(cx);
1.1143 + static int fail = 0; // TODO: remove
1.1144 + if (!rv)
1.1145 + ++fail;
1.1146 + debug_only_printf(LC_TMRegexp, "## Fail? %d, Total %d\n", (int)!rv, fail);
1.1147 out:
That's the only error when compiling. But I suppose it's TODO remove anyway ;)
|
Reporter | |
Comment 1•15 years ago
|
||
I suppose until it actually gets removed, putting that added code in its own block should fix it.
Attachment #390427 -
Flags: review?(dmandelin)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 390427 [details] [diff] [review]
patch
I think we should just remove that code. Its clearly not meant to be there.
Attachment #390427 -
Attachment is obsolete: true
Attachment #390436 -
Flags: review?(gal)
Attachment #390427 -
Flags: review?(dmandelin)
|
|
||
Updated•15 years ago
|
Attachment #390436 -
Flags: review?(gal) → review+
|
||
Comment 5•15 years ago
|
||
Yep, totally personal debugging comment that should have been removed. Sorry about that! (I can't commit it, but the patch is right.)
Assignee: general → leon.sha
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•