Closed Bug 506699 Opened 15 years ago Closed 15 years ago

js_printf doesn't always use va_end after va_start

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

http://linux.about.com/library/cmd/blcmdl3_va_start.htm va_end Each invocation of va_start must be matched by a corresponding invocation of va_end in the same function. 804 js_printf(JSPrinter *jp, const char *format, ...) 806 va_list ap; 813 va_start(ap, format); 816 if (*format == '\t') { 819 return -1; 826 if (!fp) 827 return -1; 838 if (!bp) { 840 return -1; 848 va_end(ap);
Attached patch patch (deleted) — Splinter Review
brendan gave me an rs for these changes (i'm recording that in this comment)
Assignee: general → timeless
Status: NEW → ASSIGNED
Attachment #393728 - Flags: review+
If you ever want to see it land, you may find that this once you'll need to land it yourself - jseng patches are supposed to land in tracemonkey first, and nobody who does checkin-needed has or seem to want to have a tracemonkey tree or the desire to land there, and judging by the patches that have been checkin-needed for six or seven months, nobody associated with jseng is going to step up and do them.
Keywords: checkin-needed
Whiteboard: [c-n: tracemonkey]
Whiteboard: [c-n: tracemonkey] → fixed-in-tracemonkey
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: