Closed Bug 506875 Opened 15 years ago Closed 15 years ago

fish_sound_comments_decode leaks when further allocs fail

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: coverity, memory-leak)

425 fish_sound_comments_decode (FishSound * fsound, unsigned char * comments, 447 if ((nvalue = fs_strdup_len (c, len)) == NULL) 449 if (fish_sound_comment_set_vendor (fsound, nvalue) == FISH_SOUND_ERR_OUT_OF_MEMORY) 450 return FISH_SOUND_ERR_OUT_OF_MEMORY; 489 if ((nvalue = fs_strdup_len (value, n)) == NULL) 495 if ((comment = fs_comment_new (name, nvalue)) == NULL) 496 return FISH_SOUND_ERR_OUT_OF_MEMORY; 498 if (_fs_comment_add (fsound, comment) == NULL) 499 return FISH_SOUND_ERR_OUT_OF_MEMORY; 507 if ((nvalue = fs_strdup_len (name, len)) == NULL) 510 if ((comment = fs_comment_new (nvalue, NULL)) == NULL) 511 return FISH_SOUND_ERR_OUT_OF_MEMORY; 513 if (_fs_comment_add (fsound, comment) == NULL) 514 return FISH_SOUND_ERR_OUT_OF_MEMORY;
Fixed in upstream commit 20b5cdf6fe38f61a9847e46e82da60d7ac4b7877
(In reply to comment #1) > Fixed in upstream commit 20b5cdf6fe38f61a9847e46e82da60d7ac4b7877 We got this in the liboggz update in bug 512327.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #2) > (In reply to comment #1) > > Fixed in upstream commit 20b5cdf6fe38f61a9847e46e82da60d7ac4b7877 > > We got this in the liboggz update in bug 512327. I mean the libfishsound update in bug 511584.
You need to log in before you can comment on or make changes to this bug.