Closed
Bug 507046
Opened 15 years ago
Closed 15 years ago
browser_passwordmgrdlg.js test intermittent failure
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2b1
Tracking | Status | |
---|---|---|
status1.9.1 | --- | .3-fixed |
People
(Reporter: adw, Assigned: ehsan.akhgari)
References
(Depends on 1 open bug)
Details
(Keywords: intermittent-failure, verified1.9.1)
Attachments
(1 file)
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
A focus issue?
Linux mozilla-central test everythingelse on 2009/07/28 10:01:09
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248800469.1248802504.10500.gz
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 4 logins should match 'pass' - Got 0, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 10 logins should match '' - Got 0, expected 10
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'moz' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozi' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozil' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozill' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozilla' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match 'mozilla.com' - Got 0, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 4 logins should match 'user' - Got 0, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 1 logins should match 'user ' - Got 0, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match ' user' - Got 0, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 10 logins should match 'http' - Got 0, expected 10
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 1 logins should match 'https' - Got 0, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match 'secret' - Got 0, expected 2
Assignee | ||
Comment 1•15 years ago
|
||
The problem here is bug 495751. As a solution, we need to simulate the command event for the text box in another way (instead of synthesizing VK_RETURN). Instead of calling win._filterPasswords directly as I did in bug 451352, I just dispatch a "command" event manually.
Patch forthcoming.
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #392904 -
Flags: review?(dolske)
Updated•15 years ago
|
Attachment #392904 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange] → [orange][needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2b1
Assignee | ||
Comment 4•15 years ago
|
||
Another point about this test which just occurred to me. I implemented this as a browser chrome test mainly because it was most straightforward to do so, but does that mean that other Mozilla-based apps like Thunderbird and SeaMonkey don't get to run it? If that is the case, I need to convert this to a mochitest...
Comment 5•15 years ago
|
||
SeaMonkey runs browser chrome tests if they aren't in some directory only Firefox is building, but Thunderbird can't run any mochitest-based test as it's not a browser.
Comment 6•15 years ago
|
||
Comment on attachment 392904 [details] [diff] [review]
Patch (v1)
>+ // dispatch the command event to the filter textbox
>+ let event = doc.createEvent("Events");
>+ event.initEvent("command", true, true);
>+ filter.dispatchEvent(event);
filter.doCommand();
[Implemented 8 years ago, so no excuse.]
Assignee | ||
Comment 7•15 years ago
|
||
status1.9.1:
--- → .3-fixed
Whiteboard: [orange][needs 1.9.1 landing] → [orange]
Assignee | ||
Comment 8•15 years ago
|
||
(In reply to comment #6)
> (From update of attachment 392904 [details] [diff] [review])
> >+ // dispatch the command event to the filter textbox
> >+ let event = doc.createEvent("Events");
> >+ event.initEvent("command", true, true);
> >+ filter.dispatchEvent(event);
> filter.doCommand();
> [Implemented 8 years ago, so no excuse.]
-> bug 510780.
Comment 9•15 years ago
|
||
Seems that the test works fine on 1.9.2 and 1.9.1. Marking as verified.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.1
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•