Closed Bug 507402 Opened 15 years ago Closed 15 years ago

Flash plugin mispositioned when scrolling

Categories

(Core Graveyard :: Plug-ins, defect, P1)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows NT
Type:
defect

Tracking

(status1.9.2 beta1-fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: sylvain.pasche, Assigned: roc)

References

Details

(Keywords: regression, testcase)

Attachments

(3 files, 1 obsolete file)

testcase
(deleted), text/html
Details
testcase#2
(deleted), text/html
Details
fix
(deleted), patch
jimm
: review+
benjamin
: approval1.9.2+
Details | Diff | Splinter Review
Attached file testcase (deleted) —
When scrolling with the wheel or up/down keys, flash plugin element sometimes doesn't scroll and appears above the surrounding text. That's a regression from bug 505896. See testcase, I couldn't reproduce the issue with the test plugin.
Flags: blocking1.9.2?
Assignee: nobody → roc
Flags: blocking1.9.2? → blocking1.9.2+
Attached file testcase#2 (deleted) —
I can reproduce this reliably by loading this slightly modified testcase and pressing page-down then page-up --- the plugin is gone. I've removed the inner DIVs, this is really simple.
Attached patch fix (obsolete) (deleted) — — Splinter Review
This fixes it. Because ConfigureChildren has short-circuit paths now that depend on the widget's mBounds being correct, we need to update mBounds to account for the effects of ScrollWindowEx before we call ConfigureChildren.
Attachment #393094 - Flags: review?(jmathies)
I'm not sure why the test plugin isn't affected by this. With wmode=window, it should be affected, but doesn't seem to be. But even if it was, we can't really write a test here, since the widget's mBounds always looks correct, the bug is that the HWND ends up in the wrong position.
Whiteboard: [needs review]
Attachment #393094 - Flags: review?(jmathies) → review+
This patch isn't right since we iterate over the children in aConfigurations but not other children we may have. It's also not right because ScrollWindowEx is supposed to send WM_MOVE messages to the child windows which should be updating our mBounds, so this patch shouldn't even be necessary.
Ah, but plugin window messages don't go through nsWindow::WindowProc. So that code never gets called...
Attached patch fix (deleted) — — Splinter Review
Sorry Jim, this patch makes more sense.
Attachment #393094 - Attachment is obsolete: true
Attachment #393974 - Flags: review?(jmathies)
Attachment #393974 - Flags: review?(jmathies) → review+
This looks like its fixed, see testcase in bug 511816.
http://hg.mozilla.org/mozilla-central/rev/7af754a937d6
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Needs a 1.9.2 branch push.
Comment on attachment 393974 [details] [diff] [review] fix This doesn't need approval because it's a blocker, but I'll mark it anyway!
Attachment #393974 - Flags: approval1.9.2? → approval1.9.2+
Whiteboard: [needs 192 landing]
Priority: -- → P1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: